Skip to content

Grid 64 - #18

Open
ergodicbreak wants to merge 15 commits into
schollz:paracosmsfrom
ergodicbreak:grid_64
Open

Grid 64#18
ergodicbreak wants to merge 15 commits into
schollz:paracosmsfrom
ergodicbreak:grid_64

Conversation

@ergodicbreak

@ergodicbreak ergodicbreak commented Dec 3, 2023

Copy link
Copy Markdown

Modifies grid support for 8x8 grids, per #16

I've highlighted some questions.

Changes:

  • code depends on variable grid_width instead of fixed number 16
  • 64 grids have 56 sample slots available
  • grid beat resolution is half beats rather than quarter beats (e.g. grid button [0][8] is beat four instead of two).

Not changed:

  • Sample loading; I'm assuming folders with more than eight samples are OK to load onto rows of 64 grids
  • Pset saving; I'm not sure if psets saved from a 64 grid session will load OK onto a 128 grid session, specifically because of beat resolution

I've commented the code (with TODO, DONE, and CHECK) and will clean everything up once the PR looks good.

Also I'm not that savvy with Github and pull requests and am a Lua beginner, so if I've messed anything up I am more than happy to correct it! Thanks.

@ergodicbreak

Copy link
Copy Markdown
Author

After some more testing tonight something is not right with setting the sample start/end/duration from the grid, so I'm working on that.

linear interpolation bug, the old value of 32 was based on two rows of
a 16 wide grid, scale according to grid width and it seems to work as expected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant