fix(desktop): fit History filter tabs - #49
Draft
santosli wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The History-specific override still used three columns while the UI rendered four tabs. Separately, App always requested the newest mixed 200 rows, then filtered locally, so aggregate Reference counts could be non-zero while older Reference rows were absent from the loaded page.
Verification
node --test apps/desktop/src/historyEntries.test.js apps/desktop/src/previewData.test.js apps/desktop/src/cardLayout.test.js(103/103)npm test(260/260)cargo fmt --checkcargo test --offline(CLI 29, core 324, desktop Rust 10, git 41, github 8)cargo clippy --workspace --all-targets --all-features --locked -- -D warningsnpm --workspace apps/desktop run buildnpm audit --audit-level=high(0 vulnerabilities)cargo audit(18 existing allowed warnings)git diff --checkScreenshots were inspected through the Chrome DevTools preview connector; its file sandbox did not allow saving to
/tmp, so the visual evidence is available as inline connector captures and geometry read-back.