feat(db): add catalog inspection and explain - #726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pkg.dbdesign records for the completed Q5b2 boundary.This capability intentionally keeps catalog categories, native cursor ownership, EXPLAIN, and the compiler generic bridge in one PR. They form one read-only failure domain; splitting the producer/consumer chain would duplicate the ABI, allocation, cleanup, and validation proof without leaving a useful stable intermediate consumer.
Review fixes
pkg.db.internal;Verification
pkg_db_q5b2: 10 passed locally; the required live PostgreSQL execution is CI-owned and locally skipped withoutALIGN_DB_POSTGRES_URL, while its full fixture type-check passed;_dyld_startwhile switching test binaries, so the completed phases were preserved and only the unfinishedalign_mir/parser/sema/span slices were continued;-D warnings;git diff --checkpassed.