feat(db): add migration lifecycle tooling - #723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is intentionally one larger capability boundary: the catalog policy, native locking, history codec, execution state machine, and CLI are a strict producer-to-consumer chain. Splitting them would leave dormant seams and duplicate the same ownership, failure-recovery, and cross-driver proof.
Verification
scripts/cargo.sh test -p align_driver --test pkg_db_q5a -- --nocapturescripts/pre-pr.sh --base origin/main --reviewer codex-review --review-log .git/align-review-q5a-8a66fbf2.log --findings-fixed --owner-test pkg_db_q5a -- scripts/cargo.sh test -p align_driver --test pkg_db_q5a -- --nocaptureALIGN_DB_POSTGRES_URLis not setReview
The pre-open full-diff review found two correctness issues: SQLite token-free trailing bytes were rejected, and unchanged Forbidden history was rewritten destructively. The fix ignores token-free tails, updates unchanged Applying rows in place for both adapters, restores only changed/missing snapshots, and rejects SQLite inbound foreign keys before a restore can cascade.