Fix join-point reload cache crash - #938
Merged
Merged
Conversation
Member
|
Can you check the test? It seems to be failing. |
Author
They are passing locally. |
notfood
approved these changes
Jun 1, 2026
This was referenced Jun 1, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative fix for the join-point reload crash described in #935.
Fixes a crash while creating a join-point snapshot during multiplayer reload. The old reload cache copied internal world/grid state across reload boundaries, which could leave the freshly loaded WorldGrid in an invalid state and throw from CacheForReloading during World.ExposeData.
The fix removes unsafe cache restoration for reloads and replaces it with a narrower join-point reload optimization: skip the faction-restore map drawer rebuild while the snapshot is being created, then regenerate map drawers once after the snapshot is complete.
I have never had this on the steam version, but I couldn't get the local dev branch to work untill I removed the caching.
I tried to add back some optimisations.
Mod List: