Add FromIterator implementation for Deque - #684
Conversation
|
Looks like |
Please rebase on top of main, #668 includes a fix for the MSRV CI failure. |
ab9f29a to
98e4b98
Compare
|
@sgued Should be good to go! |
|
Thank you for the PR, This looks good and in line with the rest of the crate, but I don't really like these implementions, as they make it quite easy to have unintended panics (as you correctly test for thank you). We will probably remove them in the next breaking release (see #642 (comment) and #442 for discussions around that). |
|
@sgued That's completely reasonable, I admit I was a bit surprised by the other panics too. Feel free to close this out if it doesn't align with your plans. |
Fixes #683
I took the simplest possible route of just reusing the
Extendimplementation