fix(wallet_policy): apply template derivation in into_descriptor - #1018
Open
trevarj wants to merge 1 commit into
Open
fix(wallet_policy): apply template derivation in into_descriptor#1018trevarj wants to merge 1 commit into
trevarj wants to merge 1 commit into
Conversation
BIP-388 key information items are bare KEY expressions and the derivation comes from the template's key placeholders, but the translator returned the key information item verbatim, so wpkh(@0/**) materialized as wpkh(xpub...) instead of wpkh(xpub.../<0;1>/*). - take the derivation path and wildcard from the placeholder when materializing a descriptor key - reject a key information item that is not an extended key, since there is nothing to append a derivation to Fixes rust-bitcoin#1014
Contributor
Author
|
Reminder to cherry pick into #1009 (comment) once merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BIP-388 key information items are bare KEY expressions and the derivation
comes from the template's key placeholders, but the translator returned the
key information item verbatim, so wpkh(@0/**) materialized as wpkh(xpub...)
instead of wpkh(xpub.../<0;1>/*).
materializing a descriptor key
nothing to append a derivation to
Fixes #1014