CHANGE: Expand uncert to include coefficient of variation - #210
Open
nocollier wants to merge 2 commits into
Open
CHANGE: Expand uncert to include coefficient of variation#210nocollier wants to merge 2 commits into
nocollier wants to merge 2 commits into
Conversation
…icient of variation
…if a single time span is given
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
==========================================
- Coverage 73.01% 72.91% -0.10%
==========================================
Files 48 48
Lines 4707 4734 +27
==========================================
+ Hits 3437 3452 +15
- Misses 1270 1282 +12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
nocollier
commented
Aug 20, 2026
| @@ -317,7 +317,15 @@ def __call__( | |||
|
|
|||
| # Integrate uncertainty over time like we did with mean | |||
| if dset.is_temporal(uncert): | |||
Contributor
Author
There was a problem hiding this comment.
Is it better to embed this logic in the get_scalar_uncertainty function and then return xr.Dataset()?
nocollier
commented
Aug 20, 2026
|
|
||
| Note | ||
| ---- | ||
| Uncertainty is indicated either by the presence of the `ancillary_variables` |
Contributor
Author
There was a problem hiding this comment.
Beef up docstrings
Contributor
Author
There was a problem hiding this comment.
The users (and Morgan) should understand why we cal lthis and the interval version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.