fix: preserve query string filters after delete/retry/purge - #188
Open
raphyabak wants to merge 1 commit into
Open
fix: preserve query string filters after delete/retry/purge#188raphyabak wants to merge 1 commit into
raphyabak wants to merge 1 commit into
Conversation
DeleteMonitorController, RetryMonitorController, and PurgeMonitorsController all redirected to the bare queue-monitor::index route after their action, dropping any active status/queue/name filters from the URL. Deleting a single failed job while filtered to "Failed" would silently reset the view back to unfiltered. Redirect back to wherever the request came from instead, falling back to the index route when there's no referer (e.g. a non-browser client). Fixes romanzipp#169
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeleteMonitorController,RetryMonitorController, andPurgeMonitorsControllerall redirected to the barequeue-monitor::indexroute after their action, dropping any activestatus/queue/namefilters from the URL. Deleting a single failed job while filtered to "Failed" silently reset the view back to unfiltered — matches #169.Redirect
back()to wherever the request came from instead, so the filtered URL survives the action. Falls back to the index route when there's no referer (e.g. a non-browser client hitting these endpoints directly).Fixes #169
Test plan
testDeletePreservesQueryStringFilters,testPurgePreservesQueryStringFilters,testRetryPreservesQueryStringFilters— each simulates a request from a filtered index URL (via therefererheader) and asserts the redirect preserves it.testDeleteEnabled/testPurgeEnabled/testRetryEnabled(no referer set) still pass unchanged, sinceback()falls back toqueue-monitor::indexin that case.php-cs-fixerconfig against the changed files.