Skip to content

Fix wrong source URLs for Cardiff and Blackburn with Darwen#2178

Open
deal0f49-21 wants to merge 1 commit into
robbrad:masterfrom
deal0f49-21:fix-cardiff-blackburn-source-urls
Open

Fix wrong source URLs for Cardiff and Blackburn with Darwen#2178
deal0f49-21 wants to merge 1 commit into
robbrad:masterfrom
deal0f49-21:fix-cardiff-blackburn-source-urls

Conversation

@deal0f49-21

@deal0f49-21 deal0f49-21 commented Jul 19, 2026

Copy link
Copy Markdown

Summary

  • `CardiffCouncil`'s `url` in `tests/input.json` was the generic `gov.uk` homepage instead of `cardiff.gov.uk`
  • `BlackburnCouncil`'s `url` was set to Blaby District Council's domain — a completely unrelated council

Both have `skip_get_url: true`, so this didn't affect actual date-fetching, but it's wrong for anything that displays/links this field as the council's source (e.g. an attribution UI, or a data-sources reference page).

How found

Building a per-scan "data sourced from X" attribution feature in a downstream app, which surfaces this url field to end users. Verified the correct domains against each council's real website before fixing.

Test plan

  • JSON stays valid (352 entries, same as before)
  • Confirmed cardiff.gov.uk and blackburn.gov.uk both resolve and are each council's real official site
  • Diff is minimal — only the two wrong url values changed, no other entries touched

Summary by CodeRabbit

  • Bug Fixes
    • Corrected council website links for Blackburn and Cardiff bin collection services.
    • Users are now directed to the appropriate official council websites.

Cardiff Council's url was set to the generic gov.uk homepage instead
of cardiff.gov.uk, and Blackburn with Darwen's was set to Blaby's
domain (a completely unrelated council). Found while building an
attribution feature that surfaces each council's own url field to end
users, which is used correctly for the actual scraper logic (both
entries have skip_get_url: true so this didn't affect date-fetching),
but was factually wrong for display/reference purposes.

Verified the correct domains directly against each council's real
website before fixing.
@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4e42161a-870f-4311-9151-b92692db9455

📥 Commits

Reviewing files that changed from the base of the PR and between 36d9205 and 9b1ac35.

📒 Files selected for processing (1)
  • uk_bin_collection/tests/input.json

📝 Walkthrough

Walkthrough

Corrects the configured website URLs for BlackburnCouncil and CardiffCouncil in the test input data.

Changes

Council URL corrections

Layer / File(s) Summary
Update council website URLs
uk_bin_collection/tests/input.json
BlackburnCouncil and CardiffCouncil now reference their respective council websites.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: inertiauk, robbrad

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: correcting source URLs for the Cardiff and Blackburn with Darwen council entries.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant