Expose product-owned accessibility facets

[richlander]

Summary

• add product-owned accessibility facets to type and member inventory requests/results
• classify missing/public, protected, protected internal, private protected, internal, and private accessibilities in one shared catalog
• default to public while supporting opaque-ID unions within an axis and intersections across kind/accessibility
• cross-filter descriptor counts against the opposite axis so listing and application remain consistent
• prove accessibility comes from metadata facts rather than s_, compiler-generated, or generated-looking names

Stack

Slice 3 of 3 for #3863, #3864, and #3865.

• Slice 1: Expose product-owned API kind facets #3875 — product-owned kind facets
• Parent/slice 2: Expose effective inspection view descriptors #3877 — effective inspection-view descriptors
• This slice: product-owned accessibility facets (Expose product-owned accessibility facets for type and member queries #3865)
• Deferred residual: adopt the stack and delete ACCESS_ORDER, accessBucket, client-side defaulting/filtering, lens catalogs, and body-kind inference on prototype/wasm-command-ui; the prototype is intentionally outside this main-based product stack

Validation

• dotnet run --project src/DotnetInspector.Queries.Tests -c Release: 6 passed
• dotnet build dotnet-inspect.slnx -c Release
• MAI-Code quick read: clean, with no default/count/filter, compound-accessibility, metadata-boundary, or API-contract blockers

[richlander]

Restacked onto the updated #3877 head after the lower stack integrated origin/main.

• old parent: 2cd2d6db
• new parent: c627dce9
• old head: e359d260
• new head: 23282543

git range-diff 2cd2d6db..e359d260 c627dce9..23282543:

1:  e359d260 = 1:  23282543 Expose product-owned accessibility facets

The slice content is unchanged; only its base moved.

[richlander]

A newer origin/main commit landed before review, so the lower stack was updated again and this slice was restacked onto the current #3877 head.

• old parent: c627dce9
• new parent: 2c68d482
• old head: 23282543
• new head: 394a06d4

git range-diff c627dce9..23282543 2c68d482..394a06d4:

1:  23282543 = 1:  394a06d4 Expose product-owned accessibility facets

The slice content remains unchanged; only its base moved.

[richlander]

Restacked onto the adapted #3877 head after origin/main advanced through the section-subsystem changes.

• old parent: 2c68d482
• new parent: df29a7ae
• old head: 394a06d4
• new head: 2e6e05ce

git range-diff 2c68d482..394a06d4 df29a7ae..2e6e05ce:

1:  394a06d4 = 1:  2e6e05ce Expose product-owned accessibility facets

This slice is content-identical; only its base moved. The new head passes its full Release solution build and all six query contract tests.

[richlander]

Restacked once more after origin/main advanced through #3767/#3794/#3862.

• old parent: df29a7ae
• new parent: fdaf7ef1
• old head: 2e6e05ce
• new head: 022c4173

1:  2e6e05ce = 1:  022c4173 Expose product-owned accessibility facets

The slice is content-identical. The new head passes the full Release solution build and all six query contract tests.

[richlander]

Restacked onto #3877 head 05fc8027 after the parent fixes. The range-diff preserves the accessibility slice and adds the PrivateScope review fix:

1:  022c4173 = 1:  d494a92a Expose product-owned accessibility facets
-:  -------- > 2:  24ccfbf3 Classify private-scope members as private

[richlander]

Final restack after #3875 moved the stack base. This range-diff shows the #3880 slice itself is unchanged:

1:  d494a92a = 1:  085a0bcb Expose product-owned accessibility facets
2:  24ccfbf3 ! 2:  5c5c8bcb Classify private-scope members as private
    @@ src/DotnetInspector.Queries.Tests/ApiInventoryQueryTests.cs
      
      namespace DotnetInspector.Queries.Tests;
     @@ src/DotnetInspector.Queries.Tests/ApiInventoryQueryTests.cs: public class ApiInventoryQueryTests
    -         Assert.Contains(generatedLookingPublic, publicTypes.Types);
    +             member => member.Name == "op_Addition");
          }
      
     +    [Fact]

[richlander]

Resolved the PrivateScope classification finding in 5c5c8bcb.

Method and field PrivateScope now map to the private facet, Public is handled explicitly, and unknown access masks fail visibly. A synthetic CLR image exercises PrivateScope method/field metadata through ApiSurfaceExtractor and ApiInventoryQuery, proving neither reaches the public/null fallback.

[richlander]

Restacked onto #3877 head d1a3dbc5 after its Source Locations discovery fix.

git range-diff 49caed57..5c5c8bcb d1a3dbc5..5a1735a9:

1:  085a0bcb = 1:  8aa3b5a0 Expose product-owned accessibility facets
2:  5c5c8bcb = 2:  5a1735a9 Classify private-scope members as private

The restack changed only the parent. The accessibility query class remains 8/8 passing and the full Release solution build passes at the new head.

[richlander]

Restacked onto #3877 head 548a57a1 after the lower slice's review fixes.

The accessibility implementation remains unchanged. Conflict resolution composes its AccessibilityFacets result with the new parent-owned InspectionFailures field. A follow-up test-only commit selects all accessibility facets when exercising the inherited private static-constructor regression, since this slice intentionally defaults member inventories to public accessibility.

At stack tip, the query suite passes 10/10, the Source Locations no-acquisition regression passes, and the full Release solution build succeeds.

[richlander]

Restacked onto #3877 head 7c0ee024 after its descriptor/execution fixes.

git range-diff 548a57a1..3fd20ae0 7c0ee024..397c26e4 is patch-identical for all three slice commits:

1: 0127fec1 = 1: 06d37daf Expose product-owned accessibility facets
2: c1b350c5 = 2: 5d5ae74e Classify private-scope members as private
3: 3fd20ae0 = 3: 397c26e4 Exercise constructor facets across accessibility

The restack changed only the parent. At stack tip, query tests pass 10/10, descriptor tests pass 15/15, and the full Release build succeeds.

[richlander]

Restacked onto #3877 head 2124fba9 after its discovery-annotation CI fix.

git range-diff 7c0ee024..397c26e4 2124fba9..d26fe9e5 is patch-identical for all three slice commits. The restack changed only the parent.

[richlander]

Round 36 replacement attempt 44efb1846 is superseded by the required cascading restack after the parent CI fix. New head 030f45e577e8f45dca25f76fba4f6086ef60d393 is based exactly on parent 067f0358a; range-diff maps all 43 child commits unchanged. The integrated Discovery and Source Locations gates pass 109/109 in Release. Round 36 remains pending current-head mergeability and ci-required: SUCCESS.

[richlander]

Round 36 is complete for PR 3880.

• Review models GPT-5.6 Sol and Claude Opus 5 were used for adversarial review.
• Review feedback is: converging.
• Round start: 2026-08-21 07:31 PDT.
• Round end: 2026-08-21 11:14 PDT.
• Round duration: 3:43

Fix description: Six metadata/C# defects were fixed: bounded init-modifier decoding, contained strict errors, focused visibility validation, identity-complete accessor fallback, abstract-accessor validation, and valid default-interface MethodImpl projection. The child was then exactly restacked across the parent CI fix, preserving all 43 commits. Exact head 030f45e57 is mergeable, clean, and has ci-required: SUCCESS; fixes and the required restack moved the reviewed head, so the round is complete but not review-clean.

[richlander]

Superseded by migration coordinator #4649

Per #4649's documented plan, this PR is closed without merge. Round 36's reviews were converging but the branch has had no activity since 2026-08-21, and its parent slice #3877 is now closed as superseded. #4649 explicitly directs: "do not resolve or cascade-restack the old stack merely to make it mergeable... we plan to supersede and close #3877/#3880 after their useful work has been assigned to replacement slices."

The branch, exact head, and review/range-diff evidence remain preserved as implementation evidence per #4649 — this closure does not discard that work, it stops treating this head as a merge candidate. The outstanding disposition-matrix harvest (behavioral claim → destination slice → retain/relocate/replace/drop) is tracked in #4649.