[Redis 8.10] Add integration test for search-on-timeout config - #3828
Merged
Conversation
uglide
force-pushed
the
im/search-timeout
branch
2 times, most recently
from
July 10, 2026 12:53
2338d50 to
1f31a3b
Compare
uglide
force-pushed
the
im/search-timeout
branch
from
July 10, 2026 13:45
1f31a3b to
5d444c7
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1e941d9. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Low Risk
Test-only changes in integration tests; no production library behavior is modified in this diff.
Overview
Adds Redis 8.10+ integration coverage for the global
search-on-timeoutconfig (CAE-3003) inRediSearchIntegrationTests.New helpers bulk-load 10k documents, poll
FT.INFOnum_docsvia rawdispatch(with a small RESP2/RESP3-aware decoder), and run deliberately heavy queries with a 1ms timeout so the server’s on-timeout policy always applies.Six tests toggle
CONFIG SET search-on-timeoutbetweenfailandreturn, restoringreturninfinallyblocks:fail:ftSearch,ftAggregate, andftHybridmust throwRedisCommandExecutionExceptionwhose message mentions timeout.return: same commands must succeed and expose timeout warnings onSearchReply, nested aggregateSearchReply, orHybridReply(RESP3 assumed where warnings are RESP3-only).Hybrid scenarios use a separate vector index and expensive post-processing (large KNN/COMBINE window plus repeated
formatAPPLY/sort) to force timeouts reliably.Reviewed by Cursor Bugbot for commit 0037950. Bugbot is set up for automated code reviews on this repo. Configure here.