Skip to content

[Redis 8.10] Add integration test for search-on-timeout config - #3828

Merged
uglide merged 7 commits into
mainfrom
im/search-timeout
Jul 29, 2026
Merged

[Redis 8.10] Add integration test for search-on-timeout config#3828
uglide merged 7 commits into
mainfrom
im/search-timeout

Conversation

@uglide

@uglide uglide commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Note

Low Risk
Test-only changes in integration tests; no production library behavior is modified in this diff.

Overview
Adds Redis 8.10+ integration coverage for the global search-on-timeout config (CAE-3003) in RediSearchIntegrationTests.

New helpers bulk-load 10k documents, poll FT.INFO num_docs via raw dispatch (with a small RESP2/RESP3-aware decoder), and run deliberately heavy queries with a 1ms timeout so the server’s on-timeout policy always applies.

Six tests toggle CONFIG SET search-on-timeout between fail and return, restoring return in finally blocks:

  • fail: ftSearch, ftAggregate, and ftHybrid must throw RedisCommandExecutionException whose message mentions timeout.
  • return: same commands must succeed and expose timeout warnings on SearchReply, nested aggregate SearchReply, or HybridReply (RESP3 assumed where warnings are RESP3-only).

Hybrid scenarios use a separate vector index and expensive post-processing (large KNN/COMBINE window plus repeated format APPLY/sort) to force timeouts reliably.

Reviewed by Cursor Bugbot for commit 0037950. Bugbot is set up for automated code reviews on this repo. Configure here.

@uglide
uglide force-pushed the im/search-timeout branch 2 times, most recently from 2338d50 to 1f31a3b Compare July 10, 2026 12:53
@uglide
uglide force-pushed the im/search-timeout branch from 1f31a3b to 5d444c7 Compare July 10, 2026 13:45
@uglide
uglide requested a review from a-TODO-rov July 10, 2026 13:45

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1e941d9. Configure here.

@uglide
uglide merged commit 43f9452 into main Jul 29, 2026
14 of 16 checks passed
@uglide
uglide deleted the im/search-timeout branch July 29, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants