2.5.2/fix/default external id+fixes - #1702
Merged
jochenklar merged 3 commits intoAug 6, 2026
Merged
Conversation
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
Member
Author
|
I've added the quirks that I found and my changes to the description |
jochenklar
reviewed
Aug 6, 2026
| }) | ||
| } | ||
|
|
||
| const defaultValue = values.find((value) => isDefaultValue(question, value)) |
Member
There was a problem hiding this comment.
I get most changes now, thanks for the explanation. I don't understand this update, though. I seems to fix the unit and value type for unsaved default values, which is not nessasary. I will integrate the rest in my PR. We can talk more next week.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was testing around with the collection question multi select i.c.w. the ROR provider and found some quirks.
Here are some possible fixes for #1691
Quirks and changes:
1.
Fix pending state when deleting unsaved valuesThe pending state got stuck in a forever-loop after try to delete some value
removeFromPending(pendingId)hunk indeleteValue.2.
Preserve unsaved values during provider refreshespreserveUnsavedhandling tofetchValues.3.
Preserve defaults when adding collection valuesWhat I found:
It happens when the plugin has
refresh = True, so (has_refresh: true).The fix what Codex found was:
updateValue.4.
Focus newly added select valuesSo that the cursor jumps right into the search box after opening/clicking on it.
autoFocus: value.focus.