feat: open a shell when 'wco exec' gets no command - #12
Merged
Conversation
'wco exec 2.1' now drops into an interactive shell instead of failing with a Compose usage error. The shell is chosen inside the container by a 'sh -c' shim that execs the first candidate present, defaulting to bash then sh and configurable per workspace via a new [shell] table. Also splice the service resolved from a container ID in after exec's own options rather than directly after the command: Compose stops reading options at the first positional argument, so 'wco exec 2.1 -u root whoami' previously produced 'exec php -u root whoami' and failed. Other commands keep the original position. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WvpyWdYg51uCtmwTnSqPrn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'wco exec 2.1' now drops into an interactive shell instead of failing with a Compose usage error. The shell is chosen inside the container by a 'sh -c' shim that execs the first candidate present, defaulting to bash then sh and configurable per workspace via a new [shell] table.
Also splice the service resolved from a container ID in after exec's own options rather than directly after the command: Compose stops reading options at the first positional argument, so 'wco exec 2.1 -u root whoami' previously produced
'exec php -u root whoami' and failed. Other commands keep the original position.
Claude-Session: https://claude.ai/code/session_01WvpyWdYg51uCtmwTnSqPrn