Validate scorer thresholds in process_py#489
Open
gaoflow wants to merge 1 commit into
Open
Conversation
Mirror the C++ backend conversion and range checks for score_cutoff and score_hint across the extraction and matrix APIs. Preserve custom-scorer behavior and float32 cutoff semantics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
process_cppvalidatesscore_cutoffandscore_hintagainst the scorer's declared result range, whileprocess_pysilently accepts invalid values. This affects all five public process entry points:extractOne,extract,extract_iter,cdist, andcpdist. It is the process-layer divergence noted in #488.Changes
_RF_ScorerPyflags while leaving custom scorers unchanged.size_t, including boundary rounding and exception behavior.Testing
python -m pytest tests(507 passed)black --check src/rapidfuzz/process_py.py tests/test_process.pyruff check src/rapidfuzz/process_py.py tests/test_process.pypython tools/test_scorer_typing.pypython -m mypy tools/test_process_typing.py --warn-unused-ignorespython -m pyright -p tools/pyrightconfig.json tools/test_process_typing.py