Make Windows runner subsystem production ready by amotl · Pull Request #4 · pyveci/racker

amotl · 2022-06-07T22:57:42Z

About

What the title says. 6cc13a8 was the first implementation, but it was just a prototype. Now, the necessary bells and whistles have been added and the feature graduated from postroj invoke to racker run.

Synopsis

$ racker --verbose run --rm --platform=windows/amd64 mcr.microsoft.com/windows/nanoserver:1809-amd64 \
  -- cmd /C echo Hello, world.

Documentation

See Racker Windows backend.

Examples

$ racker --verbose run --rm --platform=windows/amd64 mcr.microsoft.com/windows/servercore:ltsc2016 wmic os get caption
Microsoft Windows Server 2016 Standard Evaluation

$ racker --verbose run --rm --platform=windows/amd64 mcr.microsoft.com/windows/servercore:ltsc2019 wmic os get caption
Microsoft Windows Server 2019 Datacenter Evaluation

$ racker --verbose run --rm --platform=windows/amd64 mcr.microsoft.com/windows/servercore:ltsc2022 wmic os get caption
Microsoft Windows Server 2022 Datacenter

Backlog

For launching containers from Windows 2022 images like mcr.microsoft.com/windows/servercore:ltsc2022, we will need Add resources for building Windows Server 2022 with Docker StefanScherer/packer-windows#316 and Add support for Windows Server 2022 StefanScherer/windows-docker-machine#85 to be converged into a new upstream build. Edit: That has converged well, see StefanScherer/windows_2022_docker. Thank you, Stefan!
Automatic box selection based on requested container image. For running multiple boxes in parallel, we need Use different IP addresses for the out-of-the-box "virtualbox" variants StefanScherer/windows-docker-machine#86.
Cleanups and software tests.
Documentation.
Add use case for Python.
~~Add feature for bind-mounting a host directory, in order to run programs directly from your working tree.~~ Deferred to Add --volume option #8.

codecov-commenter · 2022-06-08T08:29:49Z

Codecov Report

Merging #4 (08a19b0) into main (fd3d4ff) will increase coverage by 0.42%.
The diff coverage is 73.52%.

❗ Current head 08a19b0 differs from pull request most recent head 26aee46. Consider uploading reports for the commit 26aee46 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   82.26%   82.68%   +0.42%     
==========================================
  Files          18       17       -1     
  Lines        1156     1161       +5     
==========================================
+ Hits          951      960       +9     
+ Misses        205      201       -4

Flag	Coverage Δ
unittests	`82.68% <73.52%> (+0.42%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
racker/cli.py	`81.65% <71.87%> (-4.43%)`	⬇️
postroj/cli.py	`81.25% <100.00%> (-0.57%)`	⬇️
postroj/exceptions.py	`100.00% <100.00%> (ø)`
postroj/util.py	`77.29% <0.00%> (+1.74%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

amotl · 2022-06-10T19:00:27Z

-                cd {self.workdir}
-                git clone https://github.com/StefanScherer/windows-docker-machine
+                cd '{self.workdir}'
+                git clone https://github.com/cicerops/windows-docker-machine --branch racker


On this spot, we would like to bring in some adjustments to the upstream infrastructure and switch back to mainline afterwards. The corresponding patch is StefanScherer/windows-docker-machine#86.

Add support for Windows Server Core 2019 and friends. - windows/servercore:ltsc2019 - windows/nanoserver:1809

…space The GHA job output already croaked about this, like: You are running out of disk space. The runner will stop working when the machine runs out of disk space. Free space left: 0 MB

- windows/servercore:ltsc2016 - windows/servercore:ltsc2022 - windows/nanoserver:ltsc2022

- Don't manipulate $PATH. To make `git` available on the program search path, use the package parameter `/GitAndUnixToolsOnPath` instead. - Rename native Windows programs like `curl.exe` and `convert.exe` to reduce ambiguity with their FOSS/GNU resp. Chocolatey-installed counterparts, also without needing to manipulate $PATH. - Also install `busybox` and `nano`.

The new names are ``RACKER_WDM_VCPUS``, ``RACKER_WDM_MEMORY``, and ``RACKER_WDM_MACHINE``. WDM means "Windows Docker Machine".

The new default values are: - RACKER_WDM_VCPUS: 4 - RACKER_WDM_MEMORY: 4096 MB

This can be used to reconfigure the Vagrant virtualization backend differently than VirtualBox. Possible values are, in alphabetical order, `hyperv`, `virtualbox`, `qemu`, `vmware_fusion`, `vmware_workstation`. It has been tested with `virtualbox` only.

This aims to build Python wheels for PyTables in a DIY manner. It uses Microsoft Visual C++ Build Tools 2015 and Anaconda, both installed using Chocolatey, and `cibuildwheel`.

…ncher

coderabbitai · 2026-07-18T15:23:19Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)

coderabbit-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: af37febd-be5d-4ba3-bacb-0b7b72c80041

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch windows

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

codecov · 2026-07-18T15:24:47Z

Codecov Report

❌ Patch coverage is 73.52941% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.83%. Comparing base (2b392b5) to head (663e015).

Files with missing lines	Patch %	Lines
racker/cli.py	71.87%	9 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   82.42%   82.83%   +0.41%     
==========================================
  Files          18       17       -1     
  Lines        1172     1177       +5     
==========================================
+ Hits          966      975       +9     
+ Misses        206      202       -4

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

amotl mentioned this pull request Jun 7, 2022

Different adjustments and improvements across the board #3

Merged

amotl force-pushed the windows branch 12 times, most recently from 97da602 to a9424e8 Compare June 8, 2022 08:29

amotl mentioned this pull request Jun 10, 2022

Add support for Windows Server 2022 StefanScherer/windows-docker-machine#85

Merged

amotl force-pushed the windows branch from a9424e8 to e11770d Compare June 10, 2022 17:29

amotl mentioned this pull request Jun 10, 2022

Use different IP addresses for the out-of-the-box "virtualbox" variants StefanScherer/windows-docker-machine#86

Merged

amotl commented Jun 10, 2022

View reviewed changes

amotl mentioned this pull request Jun 10, 2022

Optimize "time-to-shell" for Windows containers #5

Open

amotl force-pushed the windows branch from e11770d to 7e3f048 Compare June 11, 2022 21:16

amotl commented Jun 12, 2022

View reviewed changes

Comment thread postroj/winrunner.py

Comment thread doc/winrunner.rst

amotl commented Jun 12, 2022

View reviewed changes

Comment thread postroj/winrunner.py

amotl mentioned this pull request Jun 12, 2022

Use caching at different places #6

Open

amotl force-pushed the windows branch from 719ce61 to 33817da Compare June 12, 2022 09:40

amotl marked this pull request as ready for review June 12, 2022 09:43

amotl commented Jun 12, 2022

View reviewed changes

Comment thread postroj/winrunner.py Outdated

amotl force-pushed the windows branch 2 times, most recently from 857a261 to 08a19b0 Compare June 12, 2022 12:44

amotl force-pushed the windows branch from 08a19b0 to 79c20e9 Compare February 14, 2023 08:19

amotl mentioned this pull request Jan 31, 2024

Documentation: Add guidelines about debugging connectivity problems crate/crash#425

Merged

amotl mentioned this pull request Apr 15, 2024

Dockur Windows #20

Open

amotl self-assigned this Jul 18, 2026

amotl added 15 commits July 18, 2026 17:17

[windows] Make Windows runner backend production ready

6936b6a

Add support for Windows Server Core 2019 and friends. - windows/servercore:ltsc2019 - windows/nanoserver:1809

[windows] CI: Don't run Windows tests on GHA, it takes too much disk …

eaa1992

…space The GHA job output already croaked about this, like: You are running out of disk space. The runner will stop working when the machine runs out of disk space. Free space left: 0 MB

[windows] Add support for Windows Server Core 2016, 2022 and friends

8b52f30

- windows/servercore:ltsc2016 - windows/servercore:ltsc2022 - windows/nanoserver:ltsc2022

[windows] Add optional --provision option to vagrant up invocation

0c05c7b

[windows] Improve documentation about the Windows backend

894cc16

[windows] Rename environment variables for controlling the WDM

131f92e

The new names are ``RACKER_WDM_VCPUS``, ``RACKER_WDM_MEMORY``, and ``RACKER_WDM_MACHINE``. WDM means "Windows Docker Machine".

[windows] Adjust resources for Windows Docker Machine

0854213

The new default values are: - RACKER_WDM_VCPUS: 4 - RACKER_WDM_MEMORY: 4096 MB

[windows] Increase test coverage

200569f

[windows] Documentation: Add use case how to build a Python package

2fd8505

This aims to build Python wheels for PyTables in a DIY manner. It uses Microsoft Visual C++ Build Tools 2015 and Anaconda, both installed using Chocolatey, and `cibuildwheel`.

[windows] Prepare propagating the --volume option to the launcher

6c9de6e

[windows] Use Scoop package manager instead of Chocolatey

823f5b0

[windows] Update documentation

7726f52

fixup! [windows] Prepare propagating the --volume option to the lau…

f4d708c

…ncher

amotl force-pushed the windows branch from 26aee46 to f4d708c Compare July 18, 2026 15:23

[windows] Add setuptools to bring back pkg_resources

663e015

Navigation Menu

Uh oh!

Make Windows runner subsystem production ready - #4

Make Windows runner subsystem production ready#4
amotl wants to merge 16 commits into
mainfrom
windows

amotl commented Jun 7, 2022 •

edited

Loading

Uh oh!

codecov-commenter commented Jun 8, 2022 •

edited

Loading

Uh oh!

amotl Jun 10, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot commented Jul 18, 2026 •

edited

Loading

Review skipped

Uh oh!

codecov Bot commented Jul 18, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

amotl commented Jun 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

About

Synopsis

Documentation

Examples

Backlog

Uh oh!

codecov-commenter commented Jun 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

amotl Jun 10, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot commented Jul 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

codecov Bot commented Jul 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

amotl commented Jun 7, 2022 •

edited

Loading

codecov-commenter commented Jun 8, 2022 •

edited

Loading

coderabbitai Bot commented Jul 18, 2026 •

edited

Loading

codecov Bot commented Jul 18, 2026 •

edited

Loading