[fix] MD-TRT: handle c10::Error in bind_nccl_comm() probe loop - #4465
Open
apbose wants to merge 1 commit into
Open
[fix] MD-TRT: handle c10::Error in bind_nccl_comm() probe loop#4465apbose wants to merge 1 commit into
apbose wants to merge 1 commit into
Conversation
In PyTorch >= 2.13, c10d::resolve_process_group() throws c10::Error when a group name is not registered (previously returned nullptr). The probe loop in bind_nccl_comm() had no try/catch, so it crashed on i=1 even when only group "0" existed, breaking the save→load path for distributed TRT engines. Fix: - Wrap resolve_process_group() in try/catch(c10::Error) with continue (not break) so gaps from new_group(use_local_synchronization=True) don't stop the probe from finding numeric groups beyond the gap. - Apply the same treatment to the soft-return call site at the end of bind_nccl_comm() (group_name resolved but not yet registered). - Correct and expand comments to document the PyTorch numeric naming scheme and the gap scenario. Tests: add tests/py/dynamo/distributed/test_bind_nccl_probe.py with: - TestBindNcclProbeDetection: single group auto-resolve, local_sync gap, multiple groups deferral - TestBindNcclProbeBinding: explicit world pin, subgroup pin, auto-resolve - TestBindNcclProbeE2E: full save→load cycle regression test for PR #4428
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PyTorch >= 2.13, c10d::resolve_process_group() throws c10::Error when a group name is not registered (previously returned nullptr). The probe loop in bind_nccl_comm() had no try/catch, so it crashed on i=1 even when only group "0" existed, breaking the save→load path for distributed TRT engines.
Fix:
Tests: add tests/py/dynamo/distributed/test_bind_nccl_probe.py with:
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: