Consolidate qa-301 and qa-403 into qa-code parameterized function - #6
Merged
Conversation
Folds the dedicated qa-301 (301 + Location) and qa-403 (403 + HTML) function files into the existing qa-code.ts allow-list, so there is a single source of truth for fixed-status QA endpoints. The behavior at the public URLs /qa-301 and /qa-403 is byte-identical to before: - /qa-301 still returns a real HTTP 301 with Location: https://weirdanimals.life/ (no body) — qa-code's redirect branch produces the exact same Response as qa-301.ts did. - /qa-403 still returns a real HTTP 403 with Content-Type: text/html; charset=utf-8 and the same HTML body (<title>403 - QA</title>, <h1>Forbidden</h1>) — qa-code's renderHtml template is character-identical to qa-403.ts's hardcoded template when invoked with the matching title/heading. qa-status.ts is intentionally kept as its own function because it carries the QA_FORCE_500 env toggle that does not fit a generic dispatcher. After this refactor there are exactly two QA function files: qa-code.ts (all fixed statuses: 301/302/303/307/308/401/403/ 404/429) and qa-status.ts (200/500 via QA_FORCE_500). - netlify/functions/qa-code.ts: add "301" and "403" entries to the CODES allow-list; refresh the file's header docstring to list the full set of codes and explain why qa-status stays separate. - netlify/functions/qa-301.ts: deleted. - netlify/functions/qa-403.ts: deleted. - netlify.toml: repoint the existing /qa-301 and /qa-403 [[redirects]] blocks from /.netlify/functions/qa-301 and /.netlify/functions/qa-403 to /.netlify/functions/qa-code. Block positions unchanged. Comments on those two blocks updated to no longer refer to the now-removed dedicated functions. The /qa-status function and its rewrite are not touched. All QA rewrites remain before the SPA catch-all. No app routes, pages, or dependencies changed. Co-authored-by: Cursor <cursoragent@cursor.com>
✅ Deploy Preview for weirdanimals ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Folds the dedicated qa-301 (301 + Location) and qa-403 (403 + HTML) function files into the existing qa-code.ts allow-list, so there is a single source of truth for fixed-status QA endpoints. The behavior at the public URLs /qa-301 and /qa-403 is byte-identical to before:
Forbidden
) — qa-code's renderHtml template is character-identical to qa-403.ts's hardcoded template when invoked with the matching title/heading.qa-status.ts is intentionally kept as its own function because it carries the QA_FORCE_500 env toggle that does not fit a generic dispatcher. After this refactor there are exactly two QA function files: qa-code.ts (all fixed statuses: 301/302/303/307/308/401/403/ 404/429) and qa-status.ts (200/500 via QA_FORCE_500).
No app routes, pages, or dependencies changed.