Skip to content

Fix for mingw/windows compile error - #277

Closed
robe2 wants to merge 1 commit into
pramsey:masterfrom
robe2:fix-mingw-windows
Closed

Fix for mingw/windows compile error#277
robe2 wants to merge 1 commit into
pramsey:masterfrom
robe2:fix-mingw-windows

Conversation

@robe2

@robe2 robe2 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

This is to fix mingw/windows compile issue.

References #276

I still need to check some things out like lower versions of PostgreSQL cause I only tested with PostgreSQL 19.

@robe2 robe2 changed the title WIP: Fix for mingw/windows compile error Fix for mingw/windows compile error Jun 16, 2026
@robe2

robe2 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Okay works at a least as far back as PG14 which is all I care about.

And why the strlcpy references work fine in ogr_fdw.c is as I suspected, PostgreSQL has a fall back implementation for windows - https://doxygen.postgresql.org/strlcpy_8c_source.html

@robe2

robe2 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Going to close this out as the compile issue was already addressed by e39b0ff

@robe2 robe2 closed this Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant