Postgres 19 support - #68
Closed
RekGRpth wants to merge 1 commit into
Closed
Conversation
The commit postgres/postgres@a2c8983 removed proc.h from shm_mq.h.
rjuju
requested changes
Feb 28, 2026
| #endif | ||
| #include "storage/fd.h" | ||
| #include "storage/ipc.h" | ||
| #if PG_VERSION_NUM >= 190000 |
Member
There was a problem hiding this comment.
the commit message isn't very helpful as we don't include shm_mq.h, and this commit doesn't include proc.h either. I only had a quick look but it seems that lwlock.h was incidentally included via parallel.h. I think it's better to include lwlock.h for all versions, as it's a better practice to have more (and more specific) includes rather than fewer and broader scoped ones.
In any case, this should be parked in #66 so I will close this PR after the review.
Member
|
As mentioned in the review this should be parked in #66 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit postgres/postgres@a2c8983 removed proc.h from shm_mq.h.