util: add support columnar scan details (#69331) - #69426
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Ray Yan <yming0221@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
📝 WalkthroughWalkthroughBumps ChangesTiFlash Columnar Scan Execution Stats
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/retest-required |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-nextgen-202603 #69426 +/- ##
===========================================================
Coverage ? 76.2280%
===========================================================
Files ? 1935
Lines ? 540251
Branches ? 0
===========================================================
Hits ? 411823
Misses ? 128428
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
@JaySon-Huang: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/assign @bb7133 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, bb7133, coocood, JaySon-Huang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-unit-test-next-gen |
dd1be2d
into
pingcap:release-nextgen-202603
This is an cherry-pick of #69331
What problem does this PR solve?
Issue Number: close #69353
Problem Summary:
There is no execution stats summary when the query using columnar instead of tiflash.
What changed and how does it work?
Add
columnarScanContexttoTiflashStatsand collect the stats fromtipb::ColumnarScanContext.Deps
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
Summary by CodeRabbit
New Features
Bug Fixes
Chores