Bump @types/node from 22.19.7 to 26.1.1#410
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit eacb8a4. Configure here.
| "@edge-runtime/types": "^2.2.9", | ||
| "@types/jest": "^29.5.14", | ||
| "@types/node": "^22.19.7", | ||
| "@types/node": "^26.1.1", |
There was a problem hiding this comment.
Types exceed supported Node versions
Medium Severity
This bumps @types/node from 22 to 26 while engines.node is >=20.0.0 and CI only exercises Node 20/22. That breaks the version-compatibility expectation for dependencies: typechecking can accept Node 26 APIs that are unavailable on supported runtimes. The repo already pins @types/node@20 in the TS consumer matrix for this reason.
Triggered by project rule: Code Review Guidance
Reviewed by Cursor Bugbot for commit eacb8a4. Configure here.
eacb8a4 to
77b6879
Compare
…413, #414) (#415) ## Summary Combines five Dependabot PRs whose CI only failed because `PINECONE_API_KEY` is not exposed to Dependabot-triggered workflow runs (lint/build/unit/smoke were all green on each). Reopening them on a maintainer-authored branch lets the secret-gated jobs (TS compile, external-app, example app, integration) run and pass. Supersedes and closes: #403, #406, #407, #413, #414. ### npm bumps | Package | From → To | Supersedes | |---------|-----------|------------| | @edge-runtime/jest-environment | ^2.3.10 → ^4.0.0 | #413 | | @edge-runtime/types | ^2.2.9 → ^4.0.0 | #407 | | dotenv | ^16.6.1 → ^17.4.2 | #406 | | tsx | ^4.21.0 → ^4.23.1 | #414 | | typedoc | ^0.27.9 → ^0.28.20 | #414 | (transitively: `@edge-runtime/vm` 3→5, `@edge-runtime/primitives` 4.1→6.0) ### GitHub Actions bumps (#403) - `actions/checkout` v4 → v7 - `actions/setup-node` v4 → v7 - `oven-sh/setup-bun` v1 → v2 ## Local verification - ✅ `npm run build` (tsc) compiles - ✅ `npm run lint` clean - ✅ `npm run test:unit` — 574 passing - ✅ `npm run docs:build` (typedoc 0.28) — 0 errors - ✅ prettier — unchanged ## Not included The remaining Dependabot PRs have genuine breakages and are intentionally left out: `typescript@7` (#408, blocked by ts-jest peer), `eslint@10` (#409), `@types/node@26` (#410, URLPattern conflict), `@typescript-eslint@8` parser/plugin (#411/#412, must be paired), and `jest`/`@types/jest` (#405, needs `toThrowError`→`toThrow`). 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Changes are limited to devDependencies and GitHub Actions versions; the published package surface is unchanged. > > **Overview** > Bundles several safe Dependabot updates into one maintainer branch so secret-gated CI can run. > > **CI:** All workflow checkouts move from `actions/checkout@v4` to **v7**; the TypeScript compile matrix uses `actions/setup-node@v7`; Bun integration legs use `oven-sh/setup-bun@v2` instead of v1. > > **Dev dependencies:** `@edge-runtime/jest-environment` and `@edge-runtime/types` jump to **^4.0.0** (with newer `@edge-runtime/vm` / primitives for edge Jest runs). `dotenv` **^17.4.2**, `tsx` **^4.23.1**, and `typedoc` **^0.28.20** are bumped in `package.json` with matching `package-lock.json` changes—docs and integration tooling only, not the published SDK runtime. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 54e7eb3. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
72d5e43 to
82fe546
Compare
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.19.7 to 26.1.1. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-version: 26.1.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
82fe546 to
959c9f2
Compare
|
Superseded by #418, which bumps @types/node to 26.1.1 and resolves the |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
## Summary Bumps `@types/node` `22.19.7` → `26.1.1` (major, but dev-only). Supersedes and closes: #410. ## The fix `@types/node@26` added a global `URLPattern` declaration that collides (`TS2451: Cannot redeclare block-scoped variable 'URLPattern'`) with the one `@edge-runtime/types` declares — and the main `src` build was loading `@edge-runtime/types` globally via tsconfig's `types` array. `src/` only ever referenced **one** edge global (`EdgeRuntime`, in `src/utils/environment.ts`), so rather than suppressing the conflict with `skipLibCheck`, this removes the root cause: - drop `@edge-runtime/types` from `tsconfig.json`'s `types` array - declare `EdgeRuntime` locally in `environment.ts` (build-time ambient; verified it does **not** leak into the emitted `.d.ts`) ## Consumer impact: none Dev-dependency only. The published `.d.ts` references stable Node symbols (`Buffer`, `Readable`, `NodeJS.ReadableStream`) that the consumer resolves against their own `@types/node`, and the bump doesn't change those references. Ships in a **minor/patch**. ## Local verification - ✅ `npm run build` — URLPattern error resolved - ✅ `npm run lint` — clean - ✅ `npm run test:unit` — 574 passing - ✅ smoke (mocked) — 2 passing - ✅ edge integration suite still compiles & runs (removing edge types from tsconfig didn't break the edge lane) ## Note `@edge-runtime/types` is now an unused direct devDependency; left in scope here, reasonable to drop in a follow-up. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > <sup>[Cursor Bugbot](https://cursor.com/bugbot) is generating a summary for commit f54d51c. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>


Bumps @types/node from 22.19.7 to 26.1.1.
Commits
Note
Low Risk
DevDependency-only type bump with no production runtime impact; CI may surface new TypeScript errors if Node 26 typings disagree with the pinned TypeScript version.
Overview
Updates the dev-only Node.js type definitions from 22.19.7 to 26.1.1 in
package.jsonandpackage-lock.json, aligning typings with newer Node APIs.The lockfile also refreshes
undici-types(~6.21 → ~8.3) and drops stale optional Jest 29 peer entries (@jest/schemas,@jest/types,jest-util, etc.) that are no longer pulled in by this resolution. Runtime/library code is unchanged; only compile-time types for this repo’s tests and build.Reviewed by Cursor Bugbot for commit 959c9f2. Bugbot is set up for automated code reviews on this repo. Configure here.