v8 compat - #35
Merged
Merged
Conversation
amadeus
approved these changes
Jun 20, 2026
amadeus
left a comment
amadeus
left a comment
Member
There was a problem hiding this comment.
dunno this stuff well, but seems good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feedback:
We can't run your npm package in v8, which means we can't run it in our actions: Decisive finding: @pierre/storage uses Buffer (24×) and Node Readable streams (8×) — so it’s not isolate-safe even without node: imports, and getArchiveStream returns a Node stream. I can’t just drop