Make sliders use floating point values - #1773
Open
InfinityGhost wants to merge 5 commits into
Open
Conversation
InfinityGhost
marked this pull request as draft
August 16, 2020 04:14
Member
|
Hi @InfinityGhost, thanks for the PR it is really appreciated! While I agree it would be nice if the sliders where floating point vs. integers, this change is an ABI breaking change so it will have to wait for v3.0 to get merged in. |
Author
|
Is there an ETA on 3.0? |
Member
|
@InfinityGhost sorry, no definitive timeline is set for 3.0. Probably some time next year for its first official release as there's a lot of work to do. |
InfinityGhost
marked this pull request as ready for review
November 4, 2020 20:44
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes the Slider control use floating point values for all platforms. It appears that only WinForms is the only platform that doesn't support floating point values on sliders (because its so primitive), which has been accommodated for.
Closes #1772
Affected, tested, and functioning as expected