Conversation
…leted LiveHTMLDocument holds its own addRef() on the doc it's previewing, on top of any editor's ref, but only released it from close() - which is driven by the live preview session lifecycle, not by the file disappearing. Deleting the actively-previewed HTML file from the file tree left that ref dangling forever. Mirrors LiveCSSDocument's existing "deleted" handling, which already does this correctly.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LiveHTMLDocument holds its own addRef() on the doc it's previewing, on top of any editor's ref, but only released it from close() - which is driven by the live preview session lifecycle, not by the file disappearing. Deleting the actively-previewed HTML file from the file tree left that ref dangling forever.
Mirrors LiveCSSDocument's existing "deleted" handling, which already does this correctly.