Skip to content

Add LGitRemote>>defaultBranchName (again) - #71

Open
tinchodias wants to merge 5 commits into
Pharo15from
remote-default-branch-name-2
Open

Add LGitRemote>>defaultBranchName (again)#71
tinchodias wants to merge 5 commits into
Pharo15from
remote-default-branch-name-2

Conversation

@tinchodias

Copy link
Copy Markdown
Collaborator

No description provided.

@tinchodias

Copy link
Copy Markdown
Collaborator Author

More info here: #40

@tinchodias

tinchodias commented Dec 25, 2022

Copy link
Copy Markdown
Collaborator Author

I recovered the manual test's mechanism to load credentials and personal repo's urls. It worked on my computer like this:

  1. On image's directory, create a file name test_data.json.
  2. Fill with your information:
{
  "urls" : {
    "repositoryUrlHttps" : "https://github.com/tinc...ias/libgit2-pharo-bindings.git",
    "repositoryUrlSsh" : "git@github.com:tinc...dias/libgit2-pharo-bindings.git"
  },
  "credentials" : {
    "username" : "tinc...ias",
    "password" : "a5...2e"
  }
}

where password had my personal token, the one I use to push to GH
and "tin...dias" is my user (not so secret as the token but :p...)

  1. Run LGitManualFetchTest >> testDefaultBranchName


(FileSystem workingDirectory / 'test_data.json') readStreamDo: [ :stream |
dictionary := MCFileTreeJsonParser parseStream: stream ].

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This MCFileTreeJsonParser doesn't exist in P11

#(LGitReturnCodeEnum git_remote_connect #(self , LGitDirectionEnum direction , LGitRemoteCallbacks * remoteCallbacks))
options: #() No newline at end of file

^ (self ffiLibrary uniqueInstance isVersionLessThan: #(1 2))

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guillep I don't remember why I added this. My Pharo 14 with vmLatest has LGitLibrary uniqueInstance version "#(1 9 0)", I guess I can remove this change

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tell me when this is mergeable :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants