Skip to content

feat: add completeness pass and review quality improvements to pr-review - #13

Merged
k-rister merged 1 commit into
mainfrom
feat-pr-review-completeness-pass
Jul 31, 2026
Merged

feat: add completeness pass and review quality improvements to pr-review#13
k-rister merged 1 commit into
mainfrom
feat-pr-review-completeness-pass

Conversation

@k-rister

Copy link
Copy Markdown
Contributor

Summary

  • Add Pass 6 (Completeness) to catch files that should be in the diff but aren't — CLAUDE.md co-change rules, stale doc cross-references, and deduplication against earlier passes
  • Add git history context step — git blame and recent merged PRs on the same files to understand why code was written a certain way
  • Add explicit False Positive Exclusions list — pre-existing issues, unmodified lines, linter territory, pedantic nitpicks, intentional behavior changes
  • Add Confidence Check step — self-verification before finalizing the report to drop low-confidence findings

Motivated by crucible PR#645 review cycle where all three findings from the second review pass were missing co-changes in files outside the diff (bin/_help, docs/how-services-work.md, schema/services.json). The completeness pass would have caught all three in a single review. The other improvements are adopted from methodology patterns in Claude Code's built-in /code-review command.

Test plan

  • Run /crucible-tools:pr-review against a PR with a known missing co-change and verify Pass 6 catches it
  • Run against a clean PR and verify no false positives from the new passes
  • Verify git history context doesn't produce noise on files with long blame histories

🤖 Generated with Claude Code

Passes 1-5 review files that ARE in the diff but never
check for files that SHOULD be in the diff.  This caused
multiple review rounds on crucible PR#645 — three findings
from the second review were all about missing co-changes
in files outside the diff.

Add Pass 6 (Completeness) which reads the repo's CLAUDE.md
for co-change rules, greps docs/ for stale references to
changed concepts, and deduplicates against earlier passes.
Also updates the file coverage audit and output template to
accommodate findings about absent files.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@k-rister k-rister self-assigned this Jul 31, 2026
@k-rister
k-rister requested a review from a team July 31, 2026 14:54
@project-crucible-tracking project-crucible-tracking Bot moved this to In Progress in Crucible Tracking Jul 31, 2026

@atheurer atheurer left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an outstanding improvement. Adding the completeness check, git history/blame context, and clear false-positive exclusions makes the review skill incredibly robust and prevents siloed findings. Approve!

@k-rister
k-rister merged commit 783f1c8 into main Jul 31, 2026
1 check passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Crucible Tracking Jul 31, 2026
@k-rister
k-rister deleted the feat-pr-review-completeness-pass branch July 31, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants