feat: add completeness pass and review quality improvements to pr-review - #13
Merged
Conversation
Passes 1-5 review files that ARE in the diff but never check for files that SHOULD be in the diff. This caused multiple review rounds on crucible PR#645 — three findings from the second review were all about missing co-changes in files outside the diff. Add Pass 6 (Completeness) which reads the repo's CLAUDE.md for co-change rules, greps docs/ for stale references to changed concepts, and deduplicates against earlier passes. Also updates the file coverage audit and output template to accommodate findings about absent files. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
atheurer
approved these changes
Jul 31, 2026
atheurer
left a comment
There was a problem hiding this comment.
This looks like an outstanding improvement. Adding the completeness check, git history/blame context, and clear false-positive exclusions makes the review skill incredibly robust and prevents siloed findings. Approve!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git blameand recent merged PRs on the same files to understand why code was written a certain wayMotivated by crucible PR#645 review cycle where all three findings from the second review pass were missing co-changes in files outside the diff (bin/_help, docs/how-services-work.md, schema/services.json). The completeness pass would have caught all three in a single review. The other improvements are adopted from methodology patterns in Claude Code's built-in /code-review command.
Test plan
/crucible-tools:pr-reviewagainst a PR with a known missing co-change and verify Pass 6 catches it🤖 Generated with Claude Code