feat(lrsql): drop bitnami common dependency; update image to v0.9.5 - #158
Open
emmanuel wants to merge 1 commit into
Open
feat(lrsql): drop bitnami common dependency; update image to v0.9.5#158emmanuel wants to merge 1 commit into
emmanuel wants to merge 1 commit into
Conversation
Remove the vendored bitnami common library chart, which was only used for name/label/tplvalues/image helpers and legacy ingress API detection, and reimplement those inline (as in the xapi-lrs chart). Ingress now targets networking.k8s.io/v1 directly. Bump the pinned lrsql image to v0.9.5 (digest-pinned) and set appVersion, which was stale at v0.7.14. image.tag is now blank and defaults to appVersion; the digest lives in image.digest and takes precedence for the pull.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes to the lrsql chart.
Update the app image to v0.9.5
Bumps the pinned lrsql image from v0.9.3 to v0.9.5 (digest-pinned) and sets
appVersion, which was stale atv0.7.14. I checked the upstreamv0.9.3...v0.9.5diff: no schema or migration changes, and the only env change is additive (a new optionalLRSQL_CHECK_SNI). The rest is Postgres 18 support, Jetty 12, and a JDK 21 base-image bump.Drop the bitnami
commondependencycommonwas only used for name/label/tplvalues/image helpers and pre-1.19 ingress API detection, none of which earn the vendored library chart. Reimplemented inline (same approach as the xapi-lrs chart): thelrsql.imagehelper,lrsql.fullname/lrsql.labelson the ingress/gateway templates, plaintoYamlfor annotation merges, and ingress onnetworking.k8s.io/v1directly. RemovedChart.lockand the vendoredcharts/common-*.tgz.Selectors already used the chart's own
lrsql.selectorLabels, so this doesn't touch immutable Deployment/Service selector fields.Image values
image.tagis now blank and defaults toappVersion; the digest moved to its ownimage.digestfield and takes precedence for the pull. So the readable version tracksappVersion, and the supply-chain pin is preserved.Ingress behavior notes
Reimplementing the bitnami ingress inline changed a few things, all toward the standard idiom:
ingress.tls: true(+ hostname), instead of bitnami's auto-detect that only emitted it when a cert-manager annotation oringress.secretswas set. Works cleanly with cert-manager.ingress.secretsvalue was removed.pathTypeand targetsnetworking.k8s.io/v1(dropped the ≤1.18 detection).Tested with
helm templateacross image (digest / appVersion-fallback / explicit-tag), ingress, and gateway + ListenerSet permutations.