Skip to content

feat(lrsql): drop bitnami common dependency; update image to v0.9.5 - #158

Open
emmanuel wants to merge 1 commit into
mainfrom
fix/lrsql-image-v0.9.5
Open

feat(lrsql): drop bitnami common dependency; update image to v0.9.5#158
emmanuel wants to merge 1 commit into
mainfrom
fix/lrsql-image-v0.9.5

Conversation

@emmanuel

Copy link
Copy Markdown
Contributor

Two changes to the lrsql chart.

Update the app image to v0.9.5

Bumps the pinned lrsql image from v0.9.3 to v0.9.5 (digest-pinned) and sets appVersion, which was stale at v0.7.14. I checked the upstream v0.9.3...v0.9.5 diff: no schema or migration changes, and the only env change is additive (a new optional LRSQL_CHECK_SNI). The rest is Postgres 18 support, Jetty 12, and a JDK 21 base-image bump.

Drop the bitnami common dependency

common was only used for name/label/tplvalues/image helpers and pre-1.19 ingress API detection, none of which earn the vendored library chart. Reimplemented inline (same approach as the xapi-lrs chart): the lrsql.image helper, lrsql.fullname/lrsql.labels on the ingress/gateway templates, plain toYaml for annotation merges, and ingress on networking.k8s.io/v1 directly. Removed Chart.lock and the vendored charts/common-*.tgz.

Selectors already used the chart's own lrsql.selectorLabels, so this doesn't touch immutable Deployment/Service selector fields.

Image values

image.tag is now blank and defaults to appVersion; the digest moved to its own image.digest field and takes precedence for the pull. So the readable version tracks appVersion, and the supply-chain pin is preserved.

Ingress behavior notes

Reimplementing the bitnami ingress inline changed a few things, all toward the standard idiom:

  • TLS is emitted whenever ingress.tls: true (+ hostname), instead of bitnami's auto-detect that only emitted it when a cert-manager annotation or ingress.secrets was set. Works cleanly with cert-manager.
  • The now-unused ingress.secrets value was removed.
  • Ingress always sets pathType and targets networking.k8s.io/v1 (dropped the ≤1.18 detection).

Tested with helm template across image (digest / appVersion-fallback / explicit-tag), ingress, and gateway + ListenerSet permutations.

Remove the vendored bitnami common library chart, which was only used for
name/label/tplvalues/image helpers and legacy ingress API detection, and
reimplement those inline (as in the xapi-lrs chart). Ingress now targets
networking.k8s.io/v1 directly.

Bump the pinned lrsql image to v0.9.5 (digest-pinned) and set appVersion, which
was stale at v0.7.14. image.tag is now blank and defaults to appVersion; the
digest lives in image.digest and takes precedence for the pull.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant