Skip to content

i_1247 Preserve autostop contest setting - #1248

Open
johnbrvc wants to merge 1 commit into
pc2ccs:developfrom
johnbrvc:i1247_preserve_autostop_contest
Open

i_1247 Preserve autostop contest setting#1248
johnbrvc wants to merge 1 commit into
pc2ccs:developfrom
johnbrvc:i1247_preserve_autostop_contest

Conversation

@johnbrvc

Copy link
Copy Markdown
Collaborator

Description of what the PR does

Saves the original contest's autostop contest setting in the newly created ContestInformation when changes are applied.

Issue which the PR addresses

Fixes #1247

Environment in which the PR was developed (OS,IDE, Java version, etc.)

java version "1.8.0_321"
Java(TM) SE Runtime Environment (build 1.8.0_321-b07)
Java HotSpot(TM) 64-Bit Server VM (build 25.321-b07, mixed mode)

Precise steps for testing the PR (i.e., how to demonstrate that it works correctly)

  1. Bring up a contest - any contest will do.
  2. Bring up an administrator client.
  3. On the Configure Contest -> Times tab, select the contest and press the Edit button.
  4. Check the Stop contest automatically check box, and press the Update button.
  5. Close the Edit Contest Time dialog.
  6. Select the Configure Contest -> Settings tab.
  7. Change the Scoreboard Freeze Length to something like: 1:10:00 (just to affect a change on the ContestInformation).
  8. Press the Update button to save the setting.
  9. Go back to the Configure Contest -> Times tab, and select the contest and press the Edit button.
  10. Note that the Stop contest automatically checkbox is still checked.

Save the original contest's autostop contest setting in the newly created ContestInformation when changes are applied.
@johnbrvc johnbrvc added this to the 9.11.0 milestone Mar 30, 2026
@johnbrvc johnbrvc self-assigned this Mar 30, 2026
@johnbrvc johnbrvc added the One Approval A very low risk and low LOE PR/Change label Mar 30, 2026

@clevengr clevengr left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the code changes and they make sense. I ran a test with a distribution that did NOT contain this PR's fix and verfied that indeed when you mark the contest as "Auto-Stop" and then make some other configuration change, the "Auto-Stop" setting is NOT preserved. I then ran the same test on the PR code and verified that changes to the Auto-Stop setting are now preserved. I approve the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

One Approval A very low risk and low LOE PR/Change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop contest automatically setting lost if ContestInformation is updated using Settings

2 participants