Stop the BookChapterControl reopen test flaking on slow CI workers - #2694
Open
katherinejensen00 wants to merge 1 commit into
Open
Stop the BookChapterControl reopen test flaking on slow CI workers#2694katherinejensen00 wants to merge 1 commit into
katherinejensen00 wants to merge 1 commit into
Conversation
The one test in that file that drives the whole popover through userEvent (open the book list, drill into chapters, escape, reopen) overran vitest's 5s default on a contended Windows runner at ~5.4s and failed the build on main, on a merge that touched nothing near this component. It passes in ~1.5s locally, so this is worker contention rather than a regression. Raise the timeout for that single test to 30s. Deliberately per-test instead of a suite-wide `testTimeout` so a genuine hang anywhere else still fails fast. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
katherinejensen00
requested review from
irahopkinson,
jolierabideau,
lyonsil,
rolfheij-sil and
tjcouch-sil
as code owners
August 19, 2026 16:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One test in
book-chapter-control.component.test.tsxtimed out on a Windows CI worker and failed the build onmain(run 32267047403). It is the only test in that file that drives the whole popover throughuserEvent— open the book list, drill into chapters, escape, reopen — and it overran vitest's 5s default at ~5.4s. Everything else in that run passed.It is not a regression. The merge it landed on (#2683, Sync button in Simple mode) touches the toolbar, extension service, and
platform-get-resources— nothing near this component. The same test passed on Linux in the same run, and locally the whole file runs in ~3.4s with this test at ~1.5s. The runner was heavily contended (vitest reportedprepare 6957s).Why review this
Not part of the current epic. CI hygiene:
mainwent red on a flaky timeout with no code cause, so the next person to push had a red baseline to explain away. Small and self-contained.Changes
Deliberately per-test rather than a suite-wide
testTimeoutinvitest.config.ts, so a genuine hang anywhere else inplatform-bible-reactstill fails fast instead of hanging for 30s.AI Involvement
AI-assisted. Claude diagnosed the CI failure, confirmed the merged PR did not touch the component, and wrote the one-line timeout change and its comment. Reviewed by me before pushing.
Testing
book-chapter-control.component.test.tsxpasses locally (7/7)Risk Level
Low - test-only change; no production code touched, no assertions altered.
This change is