feat(config): node LAN exposure switches — monero.zmq_lan_access + tari.grpc_lan_access#761
Merged
Merged
Conversation
…_lan_access (#760) The serving side of the remote-node modes. monero.rpc_lan_access existed but published only the RPC — a remote P2Pool needs the ZMQ feed too, and the Tari base node published nothing at all, so serving another stack meant hand-run socat forwards (what the #78 bench setup did on gouda). - monero.zmq_lan_access: publishes monerod's ZMQ (18083); a separate key from rpc_lan_access on purpose — that key's documented use is wallets, and widening it would change existing deployments' exposure. - tari.grpc_lan_access: publishes the bundled Tari base node's gRPC (18142); loopback by default, matching the console-wallet publish's trust boundary. Ignored in remote mode (the service is profiled off). - Both flips to 0.0.0.0 are DEST in describe_change (host-only, like MONERO_RPC_BIND), with the no-auth trust warning in the message. - Docs: config rows + the remote-node sections now name the serving-side switches; CHANGELOG entry. - Tier 1: describe_change direction tests + the #523 black-box render extended for all three binds (default localhost, true → 0.0.0.0). Closes #760. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #760. The serving side of the remote-node modes (#103): one stack's synced nodes become consumable by other stacks through config alone.
Why
monero.rpc_lan_accessexisted but publishes only the RPC — a remote P2Pool needs the ZMQ feed too — and the Tari base node published nothing at all. Serving another stack today means hand-run socat forwards (exactly what the #78 bench setup did on gouda this week). After this PR that whole arrangement is three config keys.What
monero.zmq_lan_access(defaultfalse): publishes monerod's ZMQ feed (18083); loopback-only otherwise. A separate key fromrpc_lan_accessdeliberately — that key's documented use is wallets, and widening it would silently change existing deployments' exposure.tari.grpc_lan_access(defaultfalse): publishes the bundled Tari base node's gRPC (18142); loopback default matches the console-wallet gRPC publish's stated trust boundary. Ignored intari.mode: remote(the service is profile-gated off; nothing binds).MONERO_RPC_BIND: both binds are host-only DEST indescribe_changewhen flipping to0.0.0.0(not dashboard-editable, not confirm-gated), with the no-auth trust warning in the message. Trust model is feat(tari): remote Tari base-node mode (#103) #754's, stated at every switch: plaintext/unauthenticated feeds, trusted networks only.Coverage (tier 1, per the testing strategy)
describe_changedirection tests: DEST on open-to-LAN, INFO on close, for both new binds.127.0.0.1;true→0.0.0.0.Verified locally
make test-stack1682 passed / 0 failed ·make test-composegreen ·make test-frontendgreen (config-group completeness covers the new keys) · shellcheck/shfmt, biome, yamllint, markdownlint, docs-voice all pass.🤖 Generated with Claude Code