v19 release - #344
Merged
Merged
Conversation
Collaborator
Author
|
Lol #330
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decided to put the instructions for this in a skill. I think it's pretty clear this process should be simplified and automated in a deterministic way — e.g., we have canary releases on all PRs and auto releases on main commits. Even the tagging with
rel19could be done automatically based on a file we have in the repo.I'm also wondering we should rethink pinning a commit. The releases in omicron are tagged. Maybe we should pin
rel/v19/rc0in this repo, and then we automate the resolution of that tag to a commit hash, or we don't even need the commit hash? I do kind of like holding onto it — officially the commit a tag points to should never change on the Omicron side, but it would be nice to bail at client gen time if it did.As the skill says, this PR already contains the version bump, so after merge all we do is:
npm publishfromoxide-api/npm dist-tag add @oxide/api@0.6.0 rel19v19) and push the tag3 is not actually something we have been doing, but Mr. Robot is right that we totally should.