Skip to content

fix: remove patches that were already included in the ulmo.3 - #70

Merged
Faraz32123 merged 1 commit into
overhangio:releasefrom
GlugovGrGlib:g-glugovskiy/remove-patches-for-ulmo-3
Jun 1, 2026
Merged

fix: remove patches that were already included in the ulmo.3#70
Faraz32123 merged 1 commit into
overhangio:releasefrom
GlugovGrGlib:g-glugovskiy/remove-patches-for-ulmo-3

Conversation

@GlugovGrGlib

@GlugovGrGlib GlugovGrGlib commented May 28, 2026

Copy link
Copy Markdown
Contributor

Description

This PR fixes an issue during an image build due to applying patches for commits that are already included in the Ulmo.3 release of the credentials service.

Dockerfile:56
--------------------
  54 |
  55 |     ## Use URL safe encoding for the status list
  56 | >>> RUN curl -fsSL https://github.com/openedx/credentials/commit/0b66761d681faf9e8df5f63c0e26334d93105aa0.patch | git am
  57 |     ## Update obv3 achievement id format to urn compatible
  58 |     RUN curl -fsSL https://github.com/openedx/credentials/commit/8bc7969fab022625e600f5ba03c70ccda3ccf905.patch | git am
--------------------
ERROR: failed to build: failed to solve: process "/bin/sh -c curl -fsSL https://github.com/openedx/credentials/commit/0b66761d681faf9e8df5f63c0e26334d93105aa0.patch | git am" did not complete successfully: exit code: 128

Additional notes:

As a workaround before a new version of the tutor-credentials plugin is released the issue can be omitted by setting CREDENTIALS_REPOSITORY_VERSION: release/ulmo.2 in config.yml.

@GlugovGrGlib

Copy link
Copy Markdown
Contributor Author

@Faraz32123 This PR is ready for review, if all good can you please merge it and prepare a release for Ulmo.3 compatibility?

@Faraz32123

Copy link
Copy Markdown
Collaborator

@Faraz32123 This PR is ready for review, if all good can you please merge it and prepare a release for Ulmo.3 compatibility?

The PR looks good, I'll merge it.

@Faraz32123
Faraz32123 merged commit 2be00e3 into overhangio:release Jun 1, 2026
3 checks passed
@github-project-automation github-project-automation Bot moved this from Pending Triage to Done in Tutor project management Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants