luci-base: add member keep_order to MultiValue#8758
Conversation
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 new commit; no commit-message issues found. One inline note on missing API documentation for the new keep_order member.
Generated by Claude Code
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 new commit; no new issues found.
The only change since the last review adds the keep_order JSDoc @member block on CBIMultiValue, which resolves the previously raised documentation note.
Generated by Claude Code
Add member `keep_order` to `MultiValue`. Allow MultiValue widgets to preserve user selection order. When enabled, selected values are saved in user selection order instead of choice order. By default, `keep_order` is `false` and existing behavior is unchanged. When `true`, values are saved in the order they were selected by the user. Signed-off-by: Anya Lin <hukk1996@gmail.com>
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 new commit; no new issues found.
The head SHA changed since the last review, but the branch was only rebased onto a newer master; the PR's own changes to form.js and ui.js are byte-identical to the previously reviewed state.
Generated by Claude Code
Pull request details
Description
Add member
keep_ordertoMultiValue.Allow MultiValue widgets to preserve user selection order.
When enabled, selected values are saved in user selection order instead of choice order.
By default,
keep_orderisfalseand existing behavior is unchanged. Whentrue, values are saved in the order they were selected by the user.Screenshot or video of changes (if applicable)
Maintainer (preferred)
@systemcrash @hnyman
Tested on
OpenWrt version: OpenWrt 25.12.4 (r32933-4ccb782af7)
LuCI version: openwrt-25.12 branch (26.164.56110~44618b5)
Web browser(s):
Checklist
Signed-off-by: <my@email.address>row (viagit commit --signoff).<package name>: titlefirst line subject for packages.PKG_VERSIONin the Makefile.