Moves a few regularly used dict and list creations out of functions - #873
Merged
Conversation
Also removes a stale import in vvMixinConverters.py which shows at least 1 reverse complement func has been killed
John-F-Wagstaff
approved these changes
Jul 30, 2026
John-F-Wagstaff
left a comment
John-F-Wagstaff
left a comment
Collaborator
There was a problem hiding this comment.
This is fairly simple and looks good as is, it should have no consequences for the logic either way.
Collaborator
Author
|
Yep, just a quick tweak I missed. The aa dicts will speed up all calls a bit, the header tuple will speed up the batch tool mostly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removes a stale import in vvMixinConverters.py which shows at least
1 reverse complement func has been killed