Skip to content

OCM-00000 | ci: Update module golang.org/x/vuln to v1.6.0 - #3441

Open
red-hat-konflux-kflux-prd-rh02[bot] wants to merge 1 commit into
masterfrom
konflux/mintmaker/master/bingo-tooling
Open

OCM-00000 | ci: Update module golang.org/x/vuln to v1.6.0#3441
red-hat-konflux-kflux-prd-rh02[bot] wants to merge 1 commit into
masterfrom
konflux/mintmaker/master/bingo-tooling

Conversation

@red-hat-konflux-kflux-prd-rh02

@red-hat-konflux-kflux-prd-rh02 red-hat-konflux-kflux-prd-rh02 Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
golang.org/x/vuln v1.1.4v1.6.0 age confidence

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

Signed-off-by: red-hat-konflux-kflux-prd-rh02 <190377777+red-hat-konflux-kflux-prd-rh02[bot]@users.noreply.github.com>
@red-hat-konflux-kflux-prd-rh02 red-hat-konflux-kflux-prd-rh02 Bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 3, 2026
@openshift-ci

openshift-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Hi @red-hat-konflux-kflux-prd-rh02[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

@red-hat-konflux-kflux-prd-rh02[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/govulncheck 07cefce link false /test govulncheck

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@amandahla

Copy link
Copy Markdown
Contributor

/approve
/lgtm
govulncheck issue not related to the pr

@amandahla

Copy link
Copy Markdown
Contributor

/hold

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 3, 2026
@amandahla

Copy link
Copy Markdown
Contributor

@coderabbitai I think we had a recent issue with a PR also removing a dep from bingo, what was the solution?
Similar:
#3440

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

repo="openshift/rosa"

echo "== PR `#3440` metadata =="
gh pr view 3440 --repo "$repo" --json number,title,state,mergedAt,body,comments,commits,files \
  --jq '{number,title,state,mergedAt,body,comments:[.comments[]|{author:.author.login,createdAt,body}],commits:[.commits[]|{oid,messageHeadline}],files:[.files[]|{path,additions,deletions}]}'

echo
echo "== PR `#3440` final changed-file patches =="
gh api "repos/$repo/pulls/3440/files?per_page=100" --paginate \
  --jq '.[] | select(.filename | test("bingo|go\\.mod|go\\.sum|govuln"; "i")) | {filename,status,patch}'

echo
echo "== Relevant files and references on the current PR branch =="
fd -HI 'bingo|go\.mod|go\.sum' . -t f
rg -n -i -C 3 'golang\.org/x/vuln|govulncheck|bingo' \
  -g 'go.mod' -g 'go.sum' -g '*bingo*' -g '*.go' .

Length of output: 12718


🏁 Script executed:

#!/bin/bash
set -euo pipefail

repo="openshift/rosa"

echo "== PR `#3440` reviews and checks =="
gh pr view 3440 --repo "$repo" --json reviews,statusCheckRollup \
  --jq '{reviews:[.reviews[]|{author:.author.login,state,submittedAt,body}], checks:[.statusCheckRollup[]|{name,conclusion,status,detailsUrl}]}'

echo
echo "== PR `#3440` complete file diff =="
gh api "repos/$repo/pulls/3440/files?per_page=100" --paginate \
  --jq '.[] | {filename,status,patch}'

echo
echo "== PR `#3441` changed files and patches =="
gh api "repos/$repo/pulls/3441/files?per_page=100" --paginate \
  --jq '.[] | {filename,status,patch}'

echo
echo "== Bingo and govulncheck declarations on current branch =="
for f in .bingo/go.mod .bingo/bingo.mod .bingo/bingo.sum Makefile README.md; do
  if [ -f "$f" ]; then
    echo "--- $f ---"
    cat "$f"
  fi
done

echo
echo "== Repository-wide candidate configuration references =="
rg -n -i -C 4 'govulncheck|golang\.org/x/vuln|mockgen|bingo' \
  -g '!go.sum' -g '!*.sum' .

Length of output: 44782


🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== Current Bingo variables =="
if [ -f .bingo/Variables.mk ]; then
  rg -n -C 4 'GOVULNCHECK|MOCKGEN' .bingo/Variables.mk
else
  echo ".bingo/Variables.mk is not present in this checkout"
fi

echo
echo "== Base versus HEAD Bingo files =="
git diff --name-status origin/master...HEAD -- .bingo || true
git diff --find-renames -- .bingo || true

echo
echo "== Base govulncheck manifest and variables =="
git show origin/master:.bingo/govulncheck.mod 2>/dev/null || true
echo "--- base .bingo/Variables.mk GOVULNCHECK mapping ---"
git show origin/master:.bingo/Variables.mk 2>/dev/null | rg -n -C 4 'GOVULNCHECK' || true

echo
echo "== PR head files through GitHub =="
for path in .bingo/Variables.mk .bingo/govulncheck.mod .bingo/govulncheck.sum; do
  echo "--- $path ---"
  gh api "repos/openshift/rosa/contents/$path?ref=$(gh pr view 3441 --repo openshift/rosa --json headRefOid --jq .headRefOid)" \
    --jq '.content' 2>/dev/null | base64 --decode 2>/dev/null || echo "not present"
done

Length of output: 8775


@amandahla The similar PR, #3440, does not have a completed solution yet. It is still open, with no review or completed checks.

For this PR, the required solution is to regenerate the Bingo-managed govulncheck tool at golang.org/x/vuln v1.6.0. Do not remove the tool manifests.

The regenerated update must include:

  • .bingo/govulncheck.mod with require golang.org/x/vuln v1.6.0 // cmd/govulncheck
  • .bingo/govulncheck.sum with the v1.6.0 dependency checksums
  • .bingo/Variables.mk with GOVULNCHECK set to govulncheck-v1.6.0

The current PR deletes the manifest and checksum, but Makefile still requires $(GOVULNCHECK). Also, .bingo/Variables.mk still builds govulncheck-v1.1.4 from the deleted manifest. This will break make govulncheck.

You are interacting with an AI system.

@amandahla

Copy link
Copy Markdown
Contributor

/remove-lgtm
/remove-approve

PR will supersede #3447

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2026
@openshift-ci

openshift-ci Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: red-hat-konflux-kflux-prd-rh02[bot]
Once this PR has been reviewed and has the lgtm label, please ask for approval from amandahla. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant