Skip to content

OCPBUGS-98488: security: fix js-yaml vulnerable version - #1115

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
jgbernalp:upgrade-js-yaml
Aug 6, 2026
Merged

OCPBUGS-98488: security: fix js-yaml vulnerable version#1115
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
jgbernalp:upgrade-js-yaml

Conversation

@jgbernalp

@jgbernalp jgbernalp commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Updated the YAML processing dependency to a fixed version for more consistent application behavior.

Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Aug 6, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@jgbernalp: This pull request references Jira Issue OCPBUGS-98488, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 6, 2026
@jgbernalp

Copy link
Copy Markdown
Contributor Author

/label qe-approved

@openshift-ci openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Aug 6, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@jgbernalp: This pull request references Jira Issue OCPBUGS-98488, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jgbernalp

jgbernalp commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

/cherry-pick release-coo-ocp-4.22 release-coo-ocp-4.15 release-coo-ocp-4.12

@openshift-cherrypick-robot

Copy link
Copy Markdown

@jgbernalp: once the present PR merges, I will cherry-pick it on top of release-coo-ocp-4.22 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-coo-ocp-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2026
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 19658b28-8d65-43b8-9dc5-da0697816621

📥 Commits

Reviewing files that changed from the base of the PR and between 2241c8a and 8d0c32a.

⛔ Files ignored due to path filters (1)
  • web/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • web/package.json

Walkthrough

The web package changes the js-yaml dependency from ^4.2.0 to the exact version 4.3.1.

Changes

Dependency version

Layer / File(s) Summary
Pin js-yaml dependency
web/package.json
The package now specifies js-yaml version 4.3.1 instead of ^4.2.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: etmurasaki, peteryurkovich

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the security fix for the vulnerable js-yaml dependency, which matches the pull request changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only js-yaml entries in web/package.json and web/package-lock.json; no Ginkgo test declarations or dynamic test titles changed.
Test Structure And Quality ✅ Passed The commit only changes web/package.json and web/package-lock.json to pin js-yaml; it adds no Ginkgo tests or test-code changes, so this check is not applicable.
Microshift Test Compatibility ✅ Passed PASS: The commit changes only web/package.json and web/package-lock.json for js-yaml; it adds no Ginkgo e2e tests or MicroShift-sensitive test code.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes only web dependency manifests and adds no Ginkgo e2e tests or multi-node assumptions; SNO compatibility review is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The patch only pins js-yaml in web/package.json and web/package-lock.json; it adds no deployment, operator, controller, or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The commit changes only js-yaml dependency files; the repository builds monitoring-plugin, not an OTE binary, and contains no OTE suite or process-level stdout writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The pull request changes only dependency metadata in two JSON files; it adds no Ginkgo e2e tests or test networking and therefore does not trigger this check.
No-Weak-Crypto ✅ Passed The PR changes only js-yaml dependency and lockfile entries; the diff contains no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret-comparison changes.
Container-Privileges ✅ Passed The PR changes only js-yaml entries in web/package.json and package-lock.json; it adds no container or Kubernetes privilege settings.
No-Sensitive-Data-In-Logs ✅ Passed The commit changes only js-yaml dependency declarations and lockfile metadata; it adds no logging statements or sensitive-data output.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jgbernalp

Copy link
Copy Markdown
Contributor Author

/test e2e-monitoring

@PeterYurkovich

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2026
@openshift-ci

openshift-ci Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [PeterYurkovich,jgbernalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

@jgbernalp: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 2abd16f into openshift:main Aug 6, 2026
12 checks passed
@openshift-ci-robot

Copy link
Copy Markdown

@jgbernalp: Jira Issue OCPBUGS-98488: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-98488 has been moved to the MODIFIED state.

Details

In response to this:

Summary by CodeRabbit

  • Chores
  • Updated the YAML processing dependency to a fixed version for more consistent application behavior.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

Copy link
Copy Markdown

@jgbernalp: new pull request created: #1116

Details

In response to this:

/cherry-pick release-coo-ocp-4.22 release-coo-ocp-4.15 release-coo-ocp-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot

Copy link
Copy Markdown
Contributor

Fix included in release 5.0.0-0.nightly-2026-08-07-030024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants