OCPBUGS-105445: Fix shell arithmetic comparison in multus daemonset

[ggiguash]

Summary by CodeRabbit

• Bug Fixes
  • Improved Multus DaemonSet startup timeout handling by reliably enforcing a five-minute wait limit.

[openshift-ci-robot]

@ggiguash: This pull request references Jira Issue OCPBUGS-105445, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

The Multus DaemonSet changes the CNI configuration wait-loop timeout comparison from 5 * 60 to an explicit 300-second value.

Changes

Multus timeout handling

Layer / File(s)	Summary
CNI wait timeout assets/components/multus/06-daemonset.yaml	The wait loop compares elapsed time against 300 seconds.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

• openshift/microshift#7170: Updates the same Multus DaemonSet timeout comparison.

Suggested labels: ready-for-human-review

---

Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

• Ignore

❌ Failed checks (1 error)

Check name	Status	Explanation	Resolution
Container-Privileges	❌ Error	The Multus DaemonSet sets hostNetwork: true and privileged: true for the kube-multus container.	Remove hostNetwork and privileged mode where possible, or document the required networking access and apply the least-privilege security context.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the shell arithmetic comparison fix in the Multus DaemonSet and matches the main change.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The commit changes only one YAML shell condition; it adds or modifies no Ginkgo test declarations or test titles.
Test Structure And Quality	✅ Passed	The PR changes only one shell condition in assets/components/multus/06-daemonset.yaml; it adds no Ginkgo tests or test operations to review.
Microshift Test Compatibility	✅ Passed	The patch changes only one Multus DaemonSet YAML timeout line and adds no Ginkgo e2e tests or test declarations, so MicroShift test compatibility does not apply.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The pull request changes only a Multus DaemonSet shell timeout expression; it adds no Ginkgo e2e tests or other tests requiring SNO compatibility review.
Topology-Aware Scheduling Compatibility	✅ Passed	The only changed line fixes shell timeout arithmetic. The DaemonSet scheduling fields, including nodeSelector and tolerations, are unchanged; no new topology constraint was introduced.
Ote Binary Stdout Contract	✅ Passed	The PR changes only a Multus YAML shell condition; it contains no OTE binary, Go suite setup, or process-level stdout write.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The change only updates a shell timeout expression in a Multus DaemonSet YAML; it adds no Ginkgo e2e tests or network connectivity requirements.
No-Weak-Crypto	✅ Passed	The PR changes only a shell timeout comparison; no weak crypto, custom crypto, or secret/token comparisons appear in the added line or Multus assets.
No-Sensitive-Data-In-Logs	✅ Passed	The patch changes only the timeout comparison. It adds no logging and exposes no passwords, tokens, API keys, PII, session IDs, hostnames, or customer data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci-robot]

@ggiguash: This pull request references Jira Issue OCPBUGS-105445, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

Summary by CodeRabbit

• Bug Fixes
• Improved Multus DaemonSet startup timeout handling by reliably enforcing a five-minute wait limit.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[pacevedom]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ggiguash,pacevedom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ggiguash]

/verified by ci

[openshift-ci-robot]

@ggiguash: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 18568ca and 2 for PR HEAD 4eb8b41 in total

[ggiguash]

Failure unrelated to the change. Saving on CI cycles.
/override ci/prow/e2e-aws-tests-bootc-el10

[openshift-ci]

@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/e2e-aws-tests-bootc-el10

Details

In response to this:

Failure unrelated to the change. Saving on CI cycles.
/override ci/prow/e2e-aws-tests-bootc-el10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@ggiguash: Jira Issue OCPBUGS-105445: All pull requests linked via external trackers have merged:

• openshift/microshift#7174

All linked pull requests have the verified tag. Jira Issue OCPBUGS-105445 has been moved to the VERIFIED state.

Details

In response to this:

Summary by CodeRabbit

• Bug Fixes
• Improved Multus DaemonSet startup timeout handling by reliably enforcing a five-minute wait limit.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.