Add printer columns to PodNetworkConnectivityCheck CRD manifest

[swshende-cmd]

Summary

• Companion change to Add printer columns to PodNetworkConnectivityCheck CRD api#2977 (merged)
• Adds additionalPrinterColumns to the PodNetworkConnectivityCheck CRD manifest used by the connectivity check controller
• Without this update, the printer columns defined in openshift/api would not be applied to clusters during install or upgrade since the controller stamps this manifest onto the cluster

Change

Adds four printer columns to the CRD manifest at pkg/operator/connectivitycheckcontroller/manifests/controlplane.operator.openshift.io_podnetworkconnectivitychecks.yaml:

Column	JSONPath	Type
Target Endpoint	.spec.targetEndpoint	string
Reachable	.status.conditions[?(@.type=="Reachable")].status	string
Since	.status.conditions[?(@.type=="Reachable")].lastTransitionTime	date
Age	.metadata.creationTimestamp	date

Context

oc get podnetworkconnectivitychecks previously only showed NAME and AGE. With this change, users can see connectivity status at a glance:

NAME                                        TARGET ENDPOINT         REACHABLE   SINCE   AGE
network-check-source-...-to-kube-apiserver  10.74.238.148:6443      True        3d7h    26d
network-check-source-...-to-load-balancer   api.cluster.example:6443 True       26d     26d

Fixes: https://redhat.atlassian.net/browse/RFE-5093

Test plan

• Verified on live OCP 4.22.3 cluster (applied CRD with printer columns, all checks display correctly)
• E2E tested as part of Add printer columns to PodNetworkConnectivityCheck CRD api#2977
• Single file change, no code logic affected — only CRD metadata for display purposes

Made with Cursor

Summary by CodeRabbit

• New Features
  • Added additional information columns to connectivity check listings, including target endpoint, reachability status, status transition time, and resource age.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e8310a45-1446-480b-ae61-1e789d70ef9a

📥 Commits

Reviewing files that changed from the base of the PR and between 669f7d6 and dcf4df3.

⛔ Files ignored due to path filters (21)

• go.sum is excluded by !**/*.sum
• vendor/github.com/openshift/api/config/v1/types.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/api/config/v1/types_infrastructure.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/api/config/v1/zz_generated.featuregated-crd-manifests.yaml is excluded by !**/vendor/**, !vendor/**, !**/zz_generated*
• vendor/github.com/openshift/api/config/v1/zz_generated.swagger_doc_generated.go is excluded by !**/vendor/**, !vendor/**, !**/zz_generated*
• vendor/github.com/openshift/api/config/v1alpha1/types_cluster_monitoring.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/api/config/v1alpha1/zz_generated.deepcopy.go is excluded by !**/vendor/**, !vendor/**, !**/zz_generated*
• vendor/github.com/openshift/api/config/v1alpha1/zz_generated.model_name.go is excluded by !**/vendor/**, !vendor/**, !**/zz_generated*
• vendor/github.com/openshift/api/config/v1alpha1/zz_generated.swagger_doc_generated.go is excluded by !**/vendor/**, !vendor/**, !**/zz_generated*
• vendor/github.com/openshift/api/features.md is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/api/features/features.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/api/features/legacyfeaturegates.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/api/machine/v1beta1/types_vsphereprovider.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/api/operator/v1/types_ingresscontroller.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/api/operator/v1/zz_generated.deepcopy.go is excluded by !**/vendor/**, !vendor/**, !**/zz_generated*
• vendor/github.com/openshift/api/operator/v1/zz_generated.featuregated-crd-manifests.yaml is excluded by !**/vendor/**, !vendor/**, !**/zz_generated*
• vendor/github.com/openshift/api/operator/v1/zz_generated.swagger_doc_generated.go is excluded by !**/vendor/**, !vendor/**, !**/zz_generated*
• vendor/github.com/openshift/api/operatorcontrolplane/v1alpha1/types_conditioncheck.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/api/operatorcontrolplane/v1alpha1/zz_generated.crd-manifests/0000_10_network_01_podnetworkconnectivitychecks.crd.yaml is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/api/operatorcontrolplane/v1alpha1/zz_generated.featuregated-crd-manifests.yaml is excluded by !**/vendor/**, !vendor/**, !**/zz_generated*
• vendor/modules.txt is excluded by !**/vendor/**, !vendor/**

📒 Files selected for processing (1)

• go.mod

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

---

Walkthrough

The v1alpha1 PodNetworkConnectivityCheck CRD now shows the target endpoint, reachability status, status transition time, and resource age in resource listings. The github.com/openshift/api dependency is updated.

Changes

PodNetworkConnectivityCheck visibility

Layer / File(s)	Summary
CRD listing columns and API dependency pkg/operator/connectivitycheckcontroller/manifests/controlplane.operator.openshift.io_podnetworkconnectivitychecks.yaml, go.mod	The CRD adds printer columns for the target endpoint, reachable condition status, last transition time, and creation age. The github.com/openshift/api module uses a newer pseudo-version.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to dcf4d

This PR adds printer-column metadata so connectivity checks show target and status details in listings without changing controller logic or runtime behavior. No actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: rcarrillocruz, sanchezl

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the primary change: adding printer columns to the PodNetworkConnectivityCheck CRD manifest.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS. The PR changes the CRD manifest, dependency metadata, and vendored generated files. It does not add or modify test files. No Ginkgo test declarations or dynamic test titles appear in the PR diff…
Test Structure And Quality	✅ Passed	PASS: The pull request changes only CRD YAML metadata, dependency files, and vendored openshift/api files. The diff against origin/master contains no Ginkgo test files or test code, so the single-resp…
Microshift Test Compatibility	✅ Passed	PASS — The pull request adds no Ginkgo e2e tests. The diff changes go.mod, go.sum, vendored OpenShift API files, and CRD manifests only. No changed test paths or added It, Describe, Context, When, IsM…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The pull request adds no Ginkgo tests or other test declarations. The base-to-tip diff changes CRD printer-column metadata, dependency files, and generated vendored OpenShift API files only. The…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The pull request adds only four CRD additionalPrinterColumns and updates the vendored github.com/openshift/api dependency plus generated API files. The exact diffs contain no pod affinity, t…
Ote Binary Stdout Contract	✅ Passed	PASS — the PR changes CRD YAML, module metadata, and vendored OpenShift API declarations/generated manifests. No non-vendor Go source changed. AST and text searches found no changed main, TestMain…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS: The pull-request range changes the CRD manifest, dependency metadata, and vendored API files only. It adds or modifies no Ginkgo e2e tests and introduces no IPv4 or external-connectivity test re…
No-Weak-Crypto	✅ Passed	PASS. The PR changes only CRD printer-column metadata, the openshift/api version and its vendored API declarations/generated files. The complete diff from origin/master adds no MD5, SHA-1, DES, 3DES, …
Container-Privileges	✅ Passed	PASS. The PR changes CRD printer-column metadata and dependency/vendor files. The added YAML contains no privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or `allowPrivilegeEscalat…
No-Sensitive-Data-In-Logs	✅ Passed	PASS: The pull request adds CRD printer-column metadata and synchronizes the vendored dependency. The changed Go files contain no added logging calls, and the only new runtime-visible value is the exi…

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Stable And Deterministic Test Names

Explanation

PASS. The PR changes the CRD manifest, dependency metadata, and vendored generated files. It does not add or modify test files. No Ginkgo test declarations or dynamic test titles appear in the PR diff. The creationTimestamp value is a CRD printer-column JSONPath, not a test title.

Full details: Test Structure And Quality

Explanation

PASS: The pull request changes only CRD YAML metadata, dependency files, and vendored openshift/api files. The diff against origin/master contains no Ginkgo test files or test code, so the single-responsibility, setup/cleanup, timeout, assertion-message, and test-pattern requirements do not apply.

Full details: Microshift Test Compatibility

Explanation

PASS — The pull request adds no Ginkgo e2e tests. The diff changes go.mod, go.sum, vendored OpenShift API files, and CRD manifests only. No changed test paths or added It, Describe, Context, When, IsMicroShiftCluster, or g.Skip usage exists. The MicroShift test compatibility check is therefore not applicable.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

PASS: The pull request adds no Ginkgo tests or other test declarations. The base-to-tip diff changes CRD printer-column metadata, dependency files, and generated vendored OpenShift API files only. The SNO multi-node compatibility check is therefore not applicable.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS: The pull request adds only four CRD additionalPrinterColumns and updates the vendored github.com/openshift/api dependency plus generated API files. The exact diffs contain no pod affinity, topology spread, replica, rollout, PDB, node selector/affinity, or toleration changes. The modified CRD contains display JSONPaths only, so it introduces no topology-dependent scheduling constraint.

Full details: Ote Binary Stdout Contract

Explanation

PASS — the PR changes CRD YAML, module metadata, and vendored OpenShift API declarations/generated manifests. No non-vendor Go source changed. AST and text searches found no changed main, TestMain, suite setup, stdout, fmt.Print*, log.Print*, or klog behavior. The vendored init() functions found are unchanged scheme-registration code and do not write output. Therefore, the PR introduces no OTE binary stdout contract violation.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS: The pull-request range changes the CRD manifest, dependency metadata, and vendored API files only. It adds or modifies no Ginkgo e2e tests and introduces no IPv4 or external-connectivity test requirement.

Full details: No-Weak-Crypto

Explanation

PASS. The PR changes only CRD printer-column metadata, the openshift/api version and its vendored API declarations/generated files. The complete diff from origin/master adds no MD5, SHA-1, DES, 3DES, RC4, Blowfish, ECB, crypto imports, custom crypto, or secret/token comparisons. The changed Go additions are type declarations, generated deepcopy/OpenAPI code, and feature metadata.

Full details: Container-Privileges

Explanation

PASS. The PR changes CRD printer-column metadata and dependency/vendor files. The added YAML contains no privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation setting. It also adds no container securityContext or root user configuration. The complete PR diff has no added privilege-related security settings.

Full details: No-Sensitive-Data-In-Logs

Explanation

PASS: The pull request adds CRD printer-column metadata and synchronizes the vendored dependency. The changed Go files contain no added logging calls, and the only new runtime-visible value is the existing .spec.targetEndpoint shown by oc get; this is CLI resource output, not application logging. No changed code logs passwords, tokens, API keys, PII, session IDs, internal hostnames, or customer data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

Hi @swshende-cmd. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[everettraven]

/lgtm

[openshift-ci]

@swshende-cmd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify	669f7d6	link	true	/test verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[swshende-cmd]

/retest

[openshift-ci]

@swshende-cmd: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[swshende-cmd]

@everettraven Hi, seems need /ok-to-test and approved

[everettraven]

@swshende-cmd It looks like there is a CI check failure that needs to be fixed. Additionally, I am not an approver in this repo so I cannot add the approved label here.

@p0lyn0mial or @bertinatto may be able to help here.

[openshift-ci]

New changes are detected. LGTM label has been removed.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: everettraven, swshende-cmd
Once this PR has been reviewed and has the lgtm label, please assign bertinatto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[swshende-cmd]

Updated the PR to fix the CI verify failure:

• Bumped vendored openshift/api to include the merged printer columns change (Add printer columns to PodNetworkConnectivityCheck CRD api#2977)
• Synced the CRD manifest via make -C pkg/operator/connectivitycheckcontroller update
• Locally verified: make -C pkg/operator/connectivitycheckcontroller verify passes (manifest matches vendored source)

@p0lyn0mial @bertinatto Could you please add /ok-to-test so CI can run on the updated commit? The previous failure was because the vendored openshift/api hadn't been bumped yet. That's now fixed.

Thank you!