DO NOT MERGE: OCPBUGS-103516: Restore MADV_RANDOM to gather broken baseline

[hasbro17]

DO NOT MERGE — throwaway PR for perfscale data gathering only.

This reverts the bbolt fork replace directive merged in #395, so etcd
builds against stock upstream bbolt v1.4.3 which still calls
madvise(MADV_RANDOM). That deliberately reintroduces the compaction /
major-page-fault regression on kernel 6.4+ (RHCOS10).

Purpose: capture a fresh broken-baseline control-plane-fips-24nodes
perfscale run on the current 5.0 nightly infra, matched against a fixed
re-run, to support the upstream removal argument in etcd-io/bbolt#939.

Do not merge or review — this branch will be deleted once the baseline
data is collected.

Ref: etcd-io/bbolt#939
Ref: https://redhat.atlassian.net/browse/OCPBUGS-103516

Summary by CodeRabbit

• Chores
  • Updated underlying components to maintain consistent builds across the project and test environments.
  • Simplified platform integration and aligned component configurations.
• Bug Fixes
  • Improved reliability and compatibility through maintenance updates.
  • No new user-facing features or changes to public functionality.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@hasbro17: This pull request references Jira Issue OCPBUGS-103516, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

DO NOT MERGE — throwaway PR for perfscale data gathering only.

This reverts the bbolt fork replace directive merged in #395, so etcd
builds against stock upstream bbolt v1.4.3 which still calls
madvise(MADV_RANDOM). That deliberately reintroduces the compaction /
major-page-fault regression on kernel 6.4+ (RHCOS10).

Purpose: capture a fresh broken-baseline control-plane-fips-24nodes
perfscale run on the current 5.0 nightly infra, matched against a fixed
re-run, to support the upstream removal argument in etcd-io/bbolt#939.

Do not merge or review — this branch will be deleted once the baseline
data is collected.

Ref: etcd-io/bbolt#939
Ref: https://redhat.atlassian.net/browse/OCPBUGS-103516

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

The pull request aligns dependency versions across four Go modules. It downgrades indirect golang.org/x/sys and golang.org/x/sync versions and removes the OpenShift go.etcd.io/bbolt replacement.

Changes

Dependency alignment

Layer / File(s)	Summary
Module dependency updates etcdutl/go.mod, go.mod, server/go.mod, tests/go.mod	The modules use golang.org/x/sys v0.45.0. tests/go.mod uses golang.org/x/sync v0.20.0. All four modules remove the OpenShift go.etcd.io/bbolt replacement.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: ivanvc, ar21sm

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change and its purpose: restoring MADV_RANDOM to collect a broken baseline.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The parent-to-HEAD diff changes only four go.mod files and four go.sum files; it adds no Ginkgo test titles or test source changes.
Test Structure And Quality	✅ Passed	The PR changes only Go module and checksum metadata; the verified diff contains no Ginkgo test files or test hunks, so the listed test-quality conditions are inapplicable.
Microshift Test Compatibility	✅ Passed	The diff changes only four go.mod and four go.sum files; it adds no Ginkgo e2e tests or test declarations, so this compatibility check is inapplicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR changes only go.mod/go.sum files; it adds no Go source or Ginkgo e2e tests, so the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	The PR changes only Go module and checksum metadata; it adds or modifies no deployment manifests, operators, controllers, or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The diff changes only go.mod/go.sum dependency metadata; no Go source or process-level stdout write was introduced, and upstream bbolt's default logger discards output.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The exact commit changes only Go dependency metadata in four go.mod/go.sum pairs; no test files or Ginkgo declarations were added.
No-Weak-Crypto	✅ Passed	HEAD^..HEAD changes only Go module manifests and checksums; no source files or added MD5, SHA1, DES, RC4, Blowfish, ECB, or crypto comparison usage appears.
Container-Privileges	✅ Passed	The PR changes only Go module and checksum files; no container or Kubernetes manifests change, and no listed privilege settings are introduced.
No-Sensitive-Data-In-Logs	✅ Passed	The PR changes only Go module and checksum metadata; the diff adds no logging, sensitive-data handling, or log statements that could expose protected data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasbro17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [hasbro17]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hasbro17]

/payload-job ?

[openshift-ci]

@hasbro17: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

[hasbro17]

/test ?

[coderabbitai]

🧹 Nitpick comments (2)

go.mod (2)

103-103: 🚀 Performance & Scalability | 🔵 Trivial

Block release commands on non-release branches.

go.etcd.io/bbolt v1.4.3 resolves in all four modules. scripts/release.sh --in-place can build and publish artifacts from the current branch. Add a branch or tag guard before release, image, or packaging publication.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@go.mod` at line 103, go.mod:103-103, etcdutl/go.mod:96-96,
server/go.mod:92-92, and tests/go.mod:108-108 require no direct changes; update
scripts/release.sh to validate the current branch or tag before any release,
image, or packaging publication, and abort when the checkout is not an
authorized release ref.

---

95-95: 🔒 Security & Privacy | 🔵 Trivial

Add SBOM, provenance, and Sigstore/cosign signing to releases.

scripts/release.sh generates SHA256SUMS and scripts/release_mod.sh signs Git tags with GPG, but the release process does not generate SBOM/provenance attestations or sign artifacts with Sigstore/cosign.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@go.mod` at line 95, Update the release process implemented by
scripts/release.sh and scripts/release_mod.sh to generate SBOM and provenance
attestations and sign release artifacts with Sigstore/cosign, while preserving
existing SHA256SUMS generation and GPG tag signing. The references in go.mod at
95, etcdutl/go.mod at 85, server/go.mod at 75, and tests/go.mod at 48 and 100
require no direct changes; they only identify affected module contexts.

Source: Path instructions

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@go.mod`:
- Line 103: go.mod:103-103, etcdutl/go.mod:96-96, server/go.mod:92-92, and
tests/go.mod:108-108 require no direct changes; update scripts/release.sh to
validate the current branch or tag before any release, image, or packaging
publication, and abort when the checkout is not an authorized release ref.
- Line 95: Update the release process implemented by scripts/release.sh and
scripts/release_mod.sh to generate SBOM and provenance attestations and sign
release artifacts with Sigstore/cosign, while preserving existing SHA256SUMS
generation and GPG tag signing. The references in go.mod at 95, etcdutl/go.mod
at 85, server/go.mod at 75, and tests/go.mod at 48 and 100 require no direct
changes; they only identify affected module contexts.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: cb231bf0-a9a5-46ed-8f5d-e458d450ca17

📥 Commits

Reviewing files that changed from the base of the PR and between 609b11e and 9353928.

⛔ Files ignored due to path filters (4)

• etcdutl/go.sum is excluded by !**/*.sum
• go.sum is excluded by !**/*.sum
• server/go.sum is excluded by !**/*.sum
• tests/go.sum is excluded by !**/*.sum

📒 Files selected for processing (4)

• etcdutl/go.mod
• go.mod
• server/go.mod
• tests/go.mod

[hasbro17]

/payload-job periodic-ci-openshift-eng-ocp-perfscale-main-aws-5.0-nightly-x86-control-plane-fips-24nodes

[openshift-ci]

@hasbro17: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-eng-ocp-perfscale-main-aws-5.0-nightly-x86-control-plane-fips-24nodes

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/35a878e0-95c7-11f1-80c8-d84097d28c3d-0

[hasbro17]

/test perfscale-control-plane-6nodes

[jtaleric]

/test perfscale-control-plane-6nodes

[jtaleric]

/test perfscale-control-plane-6nodes

[openshift-ci]

@hasbro17: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/perfscale-control-plane-6nodes	9353928	link	false	/test perfscale-control-plane-6nodes

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.