fix(pypsa_io): include line shunt susceptance in per-grid to_pypsa export - #740
Open
nader-00 wants to merge 1 commit into
Open
fix(pypsa_io): include line shunt susceptance in per-grid to_pypsa export#740nader-00 wants to merge 1 commit into
nader-00 wants to merge 1 commit into
Conversation
…port The mv/lv per-grid export path dropped the "b" column from lines_df while the full-grid path (mode=None) kept it, so PyPSA silently defaulted it to 0 instead of the real value on the per-grid path. Align both paths to select the same Line columns, and add a regression test that injects a distinguishing non-zero b to catch the divergence (issue #654).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The mv/lv per-grid export path dropped the "b" column from lines_df while the full-grid path (mode=None) kept it, so PyPSA silently defaulted it to 0 instead of the real value on the per-grid path. Align both paths to select the same Line columns, and add a regression test that injects a distinguishing non-zero b to catch the divergence (issue #654).
No .rename(columns={"r_pu": "r", "x_pu": "x"}) belong to Line, only to Transformers, so it was kept untouched.
Fixes #654
Type of change
Please delete options that are not relevant.
Checklist:
pre-commithooks