Skip to content

Fix simple example notebooks: disable background map, robust LV grid … - #737

Open
nader-00 wants to merge 1 commit into
devfrom
276-improve-simple-example
Open

Fix simple example notebooks: disable background map, robust LV grid …#737
nader-00 wants to merge 1 commit into
devfrom
276-improve-simple-example

Conversation

@nader-00

@nader-00 nader-00 commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Description

plot_mv_grid_topology() defaults to background_map=True, which fetches map tiles via contextily and can hang for tens of minutes or fail without a good internet connection. Disabled in the example notebooks with a note on how to re-enable it.

Also replaced a hardcoded LV grid ("LVGrid_170173" / index 5), which has no loads with some grid data (e.g. ding0_test_network_1), with a selection that picks the LV grid with the most loads.

Fixes #276

Supersedes the abandoned, unmergeable PR #292.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • New and adjusted code is formatted using the pre-commit hooks
  • New and adjusted code includes type hinting now
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The Read the Docs documentation is compiling correctly
  • If new packages are needed, I added them the setup.py, and if needed the rtd_requirements.txt, the eDisGo_env.yml and the eDisGo_env_dev.yml.
  • I have added new features to the corresponding whatsnew file

…pick

plot_mv_grid_topology() defaults to background_map=True, which fetches
map tiles via contextily and can hang for tens of minutes or fail
without a good internet connection. Disabled in the example notebooks
with a note on how to re-enable it.

Also replaced a hardcoded LV grid ("LVGrid_170173" / index 5), which
has no loads with some grid data (e.g. ding0_test_network_1), with a
selection that picks the LV grid with the most loads.

Fixes #276

Supersedes the abandoned, unmergeable PR #292.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Improve simple example

1 participant