Skip to content

Add compartment sets asset label#674

Merged
ilkilic merged 4 commits into
mainfrom
feat/compartment-sets-asset-label
Jul 20, 2026
Merged

Add compartment sets asset label#674
ilkilic merged 4 commits into
mainfrom
feat/compartment-sets-asset-label

Conversation

@ilkilic

@ilkilic ilkilic commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add compartment_sets to AssetLabel
  • Allow compartment_sets JSON assets on Simulation entities
  • Add the PostgreSQL enum migration
  • Update the asset-label documentation
  • Add regression coverage for the Simulation allowed-label mapping

Comment on lines +21 to +22
def upgrade() -> None:
op.execute("ALTER TYPE public.assetlabel ADD VALUE IF NOT EXISTS 'compartment_sets'")

@eleftherioszisis eleftherioszisis Jul 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How was this created? Did you run make migration or generated the migration in a different way?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first version was created manually. I have now regenerated the migration with make migration

@ilkilic
ilkilic force-pushed the feat/compartment-sets-asset-label branch from 5a5fd43 to e7d9024 Compare July 20, 2026 13:11
@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
pytest 97.75% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/db/types.py 99.56% <100.00%> (+<0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ilkilic
ilkilic merged commit efc5d87 into main Jul 20, 2026
2 checks passed
@ilkilic
ilkilic deleted the feat/compartment-sets-asset-label branch July 20, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants