Skip to content

iface: bound the subscriber table #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TurkeyMan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

iface: bound the subscriber table #556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/router/iface/package.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,13 @@ nothrow @nogc:

void subscribe(InterfaceSubscriber.PacketHandler packet_handler, ref const PacketFilter filter, void* user_data = null)
{
// release builds have no bounds check: overrunning this scribbles over the
// fields behind it, and the interface then misroutes traffic it still accepts
if (_num_subscribers >= _subscribers.length)
{
log.error("subscriber table full (", cast(uint)_subscribers.length, " slots); refusing subscription");
return;
}
bool was = _num_subscribers != 0;
_subscribers[_num_subscribers++] = InterfaceSubscriber(filter, packet_handler, user_data);
if (!was)
Expand Down Expand Up @@ -742,7 +749,7 @@ package:

//private:
protected: // TODO: should probably be private?
InterfaceSubscriber[4] _subscribers;
InterfaceSubscriber[8] _subscribers;
ubyte _num_subscribers;
int _kernel_ifindex; // OS netdev ifindex when a platform backend backs this interface (0 = none)
Array!VLANInterface _vlans;
Expand Down
Loading