Type-erase command argument alignment - #483
Draft
TurkeyMan wants to merge 1 commit into
Draft
Conversation
TurkeyMan
force-pushed
the
ow/function-adapter-footprint
branch
from
August 16, 2026 01:37
bda77d8 to
776f809
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Variant[N]toArg[N]conversion.argsand rawnamed_argssinks, with compile-time type checks.Why
The previous
make_arg_tuple!funinstantiated parameter-name matching, missing and unknown argument checks, error formatting, and type conversion for every command function. Most of that work does not depend on the command's argument types.In the SmartEVSE release build, the old 42 tuple builders plus adapters occupied 19,760 bytes. The replacement uses 9,961 bytes:
The OTA image decreased from 1,743,504 to 1,732,384 bytes, saving 11,120 bytes and increasing app-slot headroom from 25,968 to 37,088 bytes.
Validation
master.