Fix the failure of the test_cleanse.py - #6462
Conversation
|
Thanks, @pwalczysko. No immediate objections from my side. |
| assert not os.path.isfile(orig_file_path_and_name) | ||
| assert not os.path.exists(logfile_path) | ||
| # The log file itself must be removed. | ||
| # On NFS, if another process still |
There was a problem hiding this comment.
Do you have any idea on what keeps a reference to the file? In a standard import workflow, I would expect all file handles to be released on completion. Is this another example of latency due to the migration of the infrastructure (i.e. would a delay also allow the test to pass.
There was a problem hiding this comment.
Do you have any idea on what keeps a reference to the file?
Blitz, I know that. More precisely dont know, did not go deeper.
(i.e. would a delay also allow the test to pass.
Delay did not work. I did not try polling though, just a plain wait. It was longer than 30 sec afai can remember and the process still did not release the file.
|
As discussed with @sbesson , the jury is out on this one. It stably passes with the fix in this PR, but not optimal and possibly underresearched. Will leave open for now. |
3 participants
What this PR does
The failing test is https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-test-integration/11/testReport/junit/OmeroPy.test.integration.clitest.test_cleanse/TestCleanseFullAdmin/testCleanseNonsenseName/
This PR is removing a line in the
test_cleanse.py.The assertion in that line which checks the existence of a path to a logfile which should have been deleted is not possible on NFS, because:
As the Blitz process is still holding the logfile open, on NFS this file cannot be deleted by NFS although the
cleansescript deletes it - it leaves a hidden file behind which the NFS renames to...nfs.Testing this PR
Check that the Jenkins build testintegration job is green.
Related reading
See #6461
cc @joshmoore @jburel @sbesson