Skip to content

Fix/showresponse model info optional - #710

Open
SaiDevaHarshaR wants to merge 3 commits into
ollama:mainfrom
SaiDevaHarshaR:fix/showresponse-model-info-optional
Open

Fix/showresponse model info optional#710
SaiDevaHarshaR wants to merge 3 commits into
ollama:mainfrom
SaiDevaHarshaR:fix/showresponse-model-info-optional

Conversation

@SaiDevaHarshaR

Copy link
Copy Markdown

What this fixes

Fixes #607 — ShowResponse raises ValidationError when cloud models
omit model_info from /api/show response.

Root cause

modelinfo field was declared as Optional but Field(alias='model_info')
had no default value, making it still required by Pydantic.

Fix

Added default=None to the Field definition:

# before
modelinfo: Optional[Mapping[str, Any]] = Field(alias='model_info')

# after  
modelinfo: Optional[Mapping[str, Any]] = Field(default=None, alias='model_info')

Testing

Added test that simulates cloud model response with missing model_info.
Previously raised ValidationError, now returns None correctly.

Closes #607

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ShowResponse ValidationError when /api/show omits model_info (cloud models)

1 participant