fix(ddg): restore broad exception catch in search() - #74
Merged
Conversation
…ne crashes PR #66 narrowed except Exception to (KeyError, ValueError, TypeError, AttributeError) — but httpx network errors (ReadTimeout, ConnectError, RemoteProtocolError) are not subclasses of those. Network errors during DDG searches propagated up and crashed the entire search-news CI step. This is a system boundary: any search failure should return [], not crash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #66 narrowed
except Exceptionto(KeyError, ValueError, TypeError, AttributeError)— but httpx network errors (ReadTimeout, ConnectError, RemoteProtocolError) are not subclasses of those. Network errors during DDG searches propagated up and crashed the entire search-news CI step (4 failures in last 4 days). This is a system boundary: any search failure should return [], not crash the pipeline.