fix(dedup): USGS type+country fallback + genesis-only place matching - #72
Merged
Merged
Conversation
USGS adapter find_existing_incident now falls back to type+country matching when event-ID family matching returns None. Fixes duplicate incidents for same-day earthquakes in the same country (e.g. Japan M6.8 + M5.6 treated as separate events). ContentStore.find_active_incident_by_type_country now checks the genesis report's places ONLY instead of all linked reports. Prevents place contamination when a multi-country report (e.g. ERCC ES+FR+TN) links to an incident and inflates its country set.
nullhack
added a commit
that referenced
this pull request
Aug 3, 2026
…dent Contaminated by place-contamination bug (fixed in PR #72). Reports moved to new incidents with proper search_keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two dedup fixes:
USGS adapter:
find_existing_incidentnow falls back to type+country matching when event-ID family matching returns None. Fixes duplicate incidents for same-day earthquakes in the same country (e.g. Japan M6.8 + M5.6 treated as separate events).ContentStore:
find_active_incident_by_type_countrynow checks the genesis report's places ONLY instead of all linked reports. Prevents place contamination when a multi-country report (e.g. ERCC ES+FR+TN) links to an incident and inflates its country set.2 files changed, +18/-14 lines.