fix: cross-container drop reverting to origin container on react-native-gesture-handler 3.x - #281
Open
nathanstitt wants to merge 1 commit into
Open
fix: cross-container drop reverting to origin container on react-native-gesture-handler 3.x #281nathanstitt wants to merge 1 commit into
nathanstitt wants to merge 1 commit into
Conversation
RNGH PR #3887 moved the end flag from onFinalize's legacy `success` second parameter into the event itself, inverted as `canceled`. The v3 gesture path still read the removed parameter, so on 3.x every normally-ended drag finalized as cancelled
|
@nathanstitt is attempting to deploy a commit to the Nuclear Pasta Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RNGH PR #3887 moved the end flag from onFinalize's legacy
successsecond parameter into the event itself, inverted ascanceled.The v3 gesture path still read the removed parameter, so on 3.x every normally-ended drag finalized as cancelled
I think this wasn't found before because the demos are all pinned to react-native-guesture-handler 3.0.0-beta.2, when I upgraded them to either 3.0.1 and 3.1.0 the cross-list demo fails.
I added code in
./compatto normalize the API as best I could, but I can remove it and lock to 3.x if you'd like to make a clean break.If you'd like I can also contribute a test as well.